From: Herbert Xu <herbert@gondor.apana.org.au>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: axboe@kernel.dk, agk@redhat.com, snitzer@redhat.com,
dm-devel@redhat.com, davem@davemloft.net, ebiggers3@gmail.com,
js1304@gmail.com, tadeusz.struk@intel.com, smueller@chronox.de,
standby24x7@gmail.com, shli@kernel.org, dan.j.williams@intel.com,
martin.petersen@oracle.com, sagig@mellanox.com,
kent.overstreet@gmail.com, keith.busch@intel.com, tj@kernel.org,
ming.lei@canonical.com, broonie@kernel.org, arnd@arndb.de,
linux-crypto@vger.kernel.org, linux-block@vger.kernel.org,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC v2 2/3] crypto: Introduce CRYPTO_ALG_BULK flag
Date: Thu, 2 Jun 2016 16:26:06 +0800 [thread overview]
Message-ID: <20160602082606.GA15226@gondor.apana.org.au> (raw)
In-Reply-To: <47e9ddd8c9ea9ad9e29c8cb027d19d8459ea1479.1464346333.git.baolin.wang@linaro.org>
On Fri, May 27, 2016 at 07:11:23PM +0800, Baolin Wang wrote:
> Now some cipher hardware engines prefer to handle bulk block rather than one
> sector (512 bytes) created by dm-crypt, cause these cipher engines can handle
> the intermediate values (IV) by themselves in one bulk block. This means we
> can increase the size of the request by merging request rather than always 512
> bytes and thus increase the hardware engine processing speed.
>
> So introduce 'CRYPTO_ALG_BULK' flag to indicate this cipher can support bulk
> mode.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
I think a better aproach would be to explicitly move the IV generation
into the crypto API, similar to how we handle IPsec. Once you do
that then every algorithm can be handled through the bulk interface.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-06-02 8:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 11:11 [RFC v2 0/3] Introduce the bulk mode method when sending request to crypto layer Baolin Wang
2016-05-27 11:11 ` [RFC v2 1/3] block: Introduce blk_bio_map_sg() to map one bio Baolin Wang
2016-06-03 14:35 ` Jens Axboe
2016-06-06 5:03 ` Baolin Wang
2016-06-03 14:38 ` Jens Axboe
2016-06-06 5:04 ` Baolin Wang
2016-05-27 11:11 ` [RFC v2 2/3] crypto: Introduce CRYPTO_ALG_BULK flag Baolin Wang
2016-06-02 8:26 ` Herbert Xu [this message]
2016-06-03 6:48 ` Baolin Wang
2016-06-03 6:51 ` Herbert Xu
2016-06-03 7:10 ` Baolin Wang
2016-06-03 7:54 ` Herbert Xu
2016-06-03 8:15 ` Baolin Wang
2016-06-03 8:21 ` Herbert Xu
2016-06-03 9:23 ` Baolin Wang
2016-06-03 10:09 ` Herbert Xu
2016-06-03 10:47 ` Baolin Wang
2016-05-27 11:11 ` [RFC v2 3/3] md: dm-crypt: Introduce the bulk mode method when sending request Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602082606.GA15226@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=agk@redhat.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=ebiggers3@gmail.com \
--cc=js1304@gmail.com \
--cc=keith.busch@intel.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@canonical.com \
--cc=sagig@mellanox.com \
--cc=shli@kernel.org \
--cc=smueller@chronox.de \
--cc=snitzer@redhat.com \
--cc=standby24x7@gmail.com \
--cc=tadeusz.struk@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).