From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161007AbcFBJpf (ORCPT ); Thu, 2 Jun 2016 05:45:35 -0400 Received: from foss.arm.com ([217.140.101.70]:43631 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932530AbcFBJpd (ORCPT ); Thu, 2 Jun 2016 05:45:33 -0400 Date: Thu, 2 Jun 2016 10:45:55 +0100 From: Lorenzo Pieralisi To: Tomasz Nowicki Cc: helgaas@kernel.org, arnd@arndb.de, will.deacon@arm.com, catalin.marinas@arm.com, rafael@kernel.org, hanjun.guo@linaro.org, okaya@codeaurora.org, jchandra@broadcom.com, robert.richter@caviumnetworks.com, mw@semihalf.com, Liviu.Dudau@arm.com, ddaney@caviumnetworks.com, wangyijing@huawei.com, Suravee.Suthikulpanit@amd.com, msalter@redhat.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, jcm@redhat.com, andrea.gallo@linaro.org, dhdang@apm.com, jeremy.linton@arm.com, liudongdong3@huawei.com, cov@codeaurora.org Subject: Re: [PATCH V8 8/9] arm64, pci, acpi: Provide ACPI-specific prerequisites for PCI bus enumeration. Message-ID: <20160602094555.GB13962@red-moon> References: <1464621262-26770-1-git-send-email-tn@semihalf.com> <1464621262-26770-9-git-send-email-tn@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464621262-26770-9-git-send-email-tn@semihalf.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 30, 2016 at 05:14:21PM +0200, Tomasz Nowicki wrote: > ACPI requires to run acpi_pci_{add|remove}_bus while new PCI bus is created. > This allows to do some ACPI-specific additional configuration, like > PCI hotplug slot enumeration. In order to fulfill these requirements, > we implement arch-specific pcibios_{add|remove}_bus calls > and call acpi_pci_{add|remove}_bus from there. > > Signed-off-by: Tomasz Nowicki > --- > arch/arm64/kernel/pci.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) Is there a reason why this has to be a standalone patch ? It is pretty much useless without patch 9 or I have stared at this series for too long. Reviewed-by: Lorenzo Pieralisi > diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c > index 336deef..3663be1 100644 > --- a/arch/arm64/kernel/pci.c > +++ b/arch/arm64/kernel/pci.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > > /* > @@ -96,4 +97,15 @@ struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root) > /* TODO: Should be revisited when implementing PCI on ACPI */ > return NULL; > } > + > +void pcibios_add_bus(struct pci_bus *bus) > +{ > + acpi_pci_add_bus(bus); > +} > + > +void pcibios_remove_bus(struct pci_bus *bus) > +{ > + acpi_pci_remove_bus(bus); > +} > + > #endif > -- > 1.9.1 >