From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753113AbcFBLWK (ORCPT ); Thu, 2 Jun 2016 07:22:10 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:35953 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751968AbcFBLWH (ORCPT ); Thu, 2 Jun 2016 07:22:07 -0400 Date: Thu, 2 Jun 2016 16:52:03 +0530 From: Viresh Kumar To: Michael Ellerman Cc: Rafael Wysocki , Benjamin Herrenschmidt , Paul Mackerras , linaro-kernel@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 3/8] cpufreq: powerenv: Fix memory leak Message-ID: <20160602112203.GO3725@vireshk-i7> References: <1464865688.11826.1.camel@ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464865688.11826.1.camel@ellerman.id.au> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02-06-16, 21:08, Michael Ellerman wrote: > On Wed, 2016-06-01 at 16:04 +0530, Viresh Kumar wrote: > > > The policy is copied (unnecessarily) and is never freed. Fix it by just > > getting a reference to the existing policy structure and putting it > > back. > > > > Signed-off-by: Viresh Kumar > > When was it broken, always? > > Cc: stable ? Its a small memory leak and its not that we will fail on something. So didn't bother to add those details, but in case they are required: Cc: # 4.3+ Fixes: 227942809b52 ("cpufreq: powernv: Restore cpu frequency to policy->cur on unthrottling") -- viresh