From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161153AbcFBO0O (ORCPT ); Thu, 2 Jun 2016 10:26:14 -0400 Received: from one.firstfloor.org ([193.170.194.197]:44024 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932839AbcFBO0N (ORCPT ); Thu, 2 Jun 2016 10:26:13 -0400 Date: Thu, 2 Jun 2016 07:26:10 -0700 From: Andi Kleen To: Nilay Vaish Cc: Andi Kleen , Andi Kleen , acme@kernel.org, jolsa@kernel.org, Linux Kernel list Subject: Re: [PATCH 2/4] perf stat: Add computation of TopDown formulas Message-ID: <20160602142610.GD13997@two.firstfloor.org> References: <1464119559-17203-1-git-send-email-andi@firstfloor.org> <1464119559-17203-2-git-send-email-andi@firstfloor.org> <20160601145648.GP22049@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 02, 2016 at 06:56:51AM -0500, Nilay Vaish wrote: > Andi, I am talking about the if statement. I don't know why it would > happen that nothing got measured. I am guessing you saw it happen. > May be we can add a comment in the patch that it is possible that all > counter values are zero and therefore we need that if statement. Sure it can happen that nothing got measured, for example if the program didn't run, or the group didn't get scheduled. -Andi