From: Mark Brown <broonie@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-msm@vger.kernel.org
Subject: Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to pm8941 lnldo
Date: Thu, 2 Jun 2016 17:24:10 +0100 [thread overview]
Message-ID: <20160602162410.GO2282@sirena.org.uk> (raw)
In-Reply-To: <20160602160432.GF1256@tuxbot>
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
On Thu, Jun 02, 2016 at 09:04:32AM -0700, Bjorn Andersson wrote:
> On Thu 02 Jun 08:50 PDT 2016, Mark Brown wrote:
> > It's more natural to use a separate set of ops, and we can optimise a
> > few things if we know the regulator is a fixed voltage one.
> In my view a fixed regulator is a thing that when you turn it on you get
> a predefined voltage, but iirc we actually need to send of a set-voltage
> request for the singly supported voltage on this ldo (which both
> implementations do today...).
> That's why I suggested Srini to do it this way, but maybe my
> interpretation of "fixed" is inaccurate?
If it only supports one voltage then shouldn't we just tell it that
voltage once at startup? Doing a call in the probe routine would be
fine, the framework doesn't need to know about that really.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-06-02 16:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 10:23 [RFC PATCH v1 0/3] regulator: qcom_smd: add list_voltage callback support Srinivas Kandagatla
2016-06-02 10:23 ` [RFC PATCH v1 1/3] regulator: helpers: consider constriants in list_voltage_linear_range Srinivas Kandagatla
2016-06-02 11:05 ` Mark Brown
2016-06-02 11:53 ` Srinivas Kandagatla
2016-06-02 10:23 ` [RFC PATCH v1 2/3] regulator: qcom_smd: add list_voltage callback Srinivas Kandagatla
2016-06-03 10:40 ` Mark Brown
2016-06-03 11:24 ` Srinivas Kandagatla
2016-06-13 15:48 ` Applied "regulator: qcom_smd: add list_voltage callback" to the regulator tree Mark Brown
2016-06-02 10:23 ` [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to pm8941 lnldo Srinivas Kandagatla
2016-06-02 14:49 ` Mark Brown
2016-06-02 14:57 ` Srinivas Kandagatla
2016-06-02 15:50 ` Mark Brown
2016-06-02 16:04 ` Bjorn Andersson
2016-06-02 16:24 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602162410.GO2282@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).