From: Tony Lindgren <tony@atomide.com>
To: Robert Nelson <robertcnelson@gmail.com>
Cc: Yong Li <yong.b.li@intel.com>,
Benoit Cousson <bcousson@baylibre.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux kernel <linux-kernel@vger.kernel.org>,
sdliyong@gmail.com
Subject: Re: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry
Date: Thu, 2 Jun 2016 10:56:35 -0700 [thread overview]
Message-ID: <20160602175635.GG5995@atomide.com> (raw)
In-Reply-To: <CAOCHtYiWYrwSidHnKv4siFT-wU=tt5-YeDTwbM022ZTxdPFYYA@mail.gmail.com>
* Robert Nelson <robertcnelson@gmail.com> [160602 10:48]:
> On Thu, Jun 2, 2016 at 12:39 PM, Tony Lindgren <tony@atomide.com> wrote:
> >
> > * Robert Nelson <robertcnelson@gmail.com> [160602 10:39]:
> > > On Thu, Jun 2, 2016 at 2:41 AM, Yong Li <yong.b.li@intel.com> wrote:
> > >
> > > > From: Yong Li <sdliyong@gmail.com>
> > > >
> > > > Without this patch, I2C-1 is missing on beaglebone black boards
> > > >
> > > > Signed-off-by: Yong Li <sdliyong@gmail.com>
> > > > ---
> > > > arch/arm/boot/dts/am335x-boneblack.dts | 15 +++++++++++++++
> > > > 1 file changed, 15 insertions(+)
> > > >
> > >
> > >
> > > This is also 'common' for the white/green, if your really going to push
> > > this, please add it to:
> > >
> > > am335x-bone-common.dtsi
> >
> > But isn't this exposed on the cape pins? So the use can be
> > whatever for these pins?
>
> That is correct, "i2c1" is on the cape connector, with no primary
> function defined.
>
> Currently on mainline, the board and cape eeprom i2c bus's are enabled.
>
> i2c0 = board eeprom
> i2c2 = 'cape' eeprom
>
> personally, nak by me to add i2c1 by default, should use overlay's to enable it.
Yes sounds like the best we can do is define it but set it with
status = "disabled" for now.
Regards,
Tony
next prev parent reply other threads:[~2016-06-02 17:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 7:41 [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry Yong Li
[not found] ` <CAOCHtYib9YxckneM-j0Gk1YE=MnvAwAhvDjEDEuFJbH6W3EcWA@mail.gmail.com>
2016-06-02 17:39 ` Tony Lindgren
2016-06-02 17:45 ` Robert Nelson
2016-06-02 17:56 ` Tony Lindgren [this message]
2016-06-03 5:46 ` Li, Yong B
2016-06-07 6:00 ` Tony Lindgren
2016-06-07 6:14 ` Li, Yong B
2016-06-07 17:14 ` Robert Nelson
2016-06-08 7:11 ` Li, Yong B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602175635.GG5995@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robertcnelson@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sdliyong@gmail.com \
--cc=yong.b.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).