From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933114AbcFBR4l (ORCPT ); Thu, 2 Jun 2016 13:56:41 -0400 Received: from muru.com ([72.249.23.125]:55378 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932324AbcFBR4k (ORCPT ); Thu, 2 Jun 2016 13:56:40 -0400 Date: Thu, 2 Jun 2016 10:56:35 -0700 From: Tony Lindgren To: Robert Nelson Cc: Yong Li , Benoit Cousson , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , "linux-omap@vger.kernel.org" , devicetree , "linux-arm-kernel@lists.infradead.org" , linux kernel , sdliyong@gmail.com Subject: Re: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry Message-ID: <20160602175635.GG5995@atomide.com> References: <1464853310-8738-1-git-send-email-yong.b.li@intel.com> <20160602173932.GF5995@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Robert Nelson [160602 10:48]: > On Thu, Jun 2, 2016 at 12:39 PM, Tony Lindgren wrote: > > > > * Robert Nelson [160602 10:39]: > > > On Thu, Jun 2, 2016 at 2:41 AM, Yong Li wrote: > > > > > > > From: Yong Li > > > > > > > > Without this patch, I2C-1 is missing on beaglebone black boards > > > > > > > > Signed-off-by: Yong Li > > > > --- > > > > arch/arm/boot/dts/am335x-boneblack.dts | 15 +++++++++++++++ > > > > 1 file changed, 15 insertions(+) > > > > > > > > > > > > > This is also 'common' for the white/green, if your really going to push > > > this, please add it to: > > > > > > am335x-bone-common.dtsi > > > > But isn't this exposed on the cape pins? So the use can be > > whatever for these pins? > > That is correct, "i2c1" is on the cape connector, with no primary > function defined. > > Currently on mainline, the board and cape eeprom i2c bus's are enabled. > > i2c0 = board eeprom > i2c2 = 'cape' eeprom > > personally, nak by me to add i2c1 by default, should use overlay's to enable it. Yes sounds like the best we can do is define it but set it with status = "disabled" for now. Regards, Tony