From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932885AbcFBUe1 (ORCPT ); Thu, 2 Jun 2016 16:34:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39326 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932171AbcFBUeZ (ORCPT ); Thu, 2 Jun 2016 16:34:25 -0400 Date: Thu, 2 Jun 2016 22:34:13 +0200 From: Jiri Olsa To: He Kuang Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 13/14] perf callchain: Support x86 target platform Message-ID: <20160602203413.GB26647@krava> References: <1464861326-22677-1-git-send-email-hekuang@huawei.com> <1464861326-22677-14-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464861326-22677-14-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 02 Jun 2016 20:34:24 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 02, 2016 at 09:55:25AM +0000, He Kuang wrote: SNIP > @@ -31,9 +33,17 @@ int unwind__prepare_access(struct thread *thread, struct map *map) > return 0; > > arch = normalize_arch(thread->mg->machine->env->arch); > - pr_debug("unwind: target platform=%s\n", arch); > > - unwind__register_ops(thread, local_unwind_libunwind_ops); > + if (!strcmp(arch, "x86")) > + if (dso_type != DSO__TYPE_64BIT) > + ops = x86_32_unwind_libunwind_ops; pleas enclose above into { } thanks, jirka