From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: Chao Yu <chao@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: fix to redirty page if fail to gc data page
Date: Thu, 2 Jun 2016 22:08:58 -0700 [thread overview]
Message-ID: <20160603050858.GA24882@jaegeuk> (raw)
In-Reply-To: <a09543b8-349e-d2cc-0e15-f2bf82d4dcfa@huawei.com>
On Tue, May 31, 2016 at 02:10:50PM +0800, Chao Yu wrote:
> Hi Jaegeuk,
>
> On 2016/5/30 10:37, Jaegeuk Kim wrote:
> > Hi Chao,
> >
> > On Sat, May 21, 2016 at 01:19:11PM +0800, Chao Yu wrote:
> >> From: Chao Yu <yuchao0@huawei.com>
> >>
> >> If we fail to move data page during foreground GC, we should give another
> >> chance to writeback that page which was set dirty previously by writer.
> >>
> >> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> >> ---
> >> fs/f2fs/gc.c | 5 ++++-
> >> 1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> >> index 38d56f6..ee213a8 100644
> >> --- a/fs/f2fs/gc.c
> >> +++ b/fs/f2fs/gc.c
> >> @@ -653,12 +653,15 @@ static void move_data_page(struct inode *inode, block_t bidx, int gc_type)
> >> .page = page,
> >> .encrypted_page = NULL,
> >> };
> >> + bool is_dirty = PageDirty(page);
> >> +
> >> set_page_dirty(page);
> >> f2fs_wait_on_page_writeback(page, DATA, true);
> >> if (clear_page_dirty_for_io(page))
> >> inode_dec_dirty_pages(inode);
> >> set_cold_data(page);
> >> - do_write_data_page(&fio);
> >> + if (do_write_data_page(&fio) && is_dirty)
> >> + set_page_dirty(page);
> >
> > If this page is truncated with -ENOENT, we don't need to set it dirty again.
>
> Agree
>
> > I expect that, if we get an error here, do_garbage_collect() would retry FG_GC
>
> IIRC, you have reworked the FG_GC flows changed from an infinite loop to trying
> do the movement just one time. Here, I think if there are just few of blocks are
> failed to be moved, we can give one more time for retrying. How do you think?
Mostly I expected here -ENOENT caused by race condition.
Do we have another expectation?
Thanks,
>
> > again.
> >
> > Thanks,
> >
> >> clear_cold_data(page);
> >> }
> >> out:
> >> --
> >> 2.7.2
> > .
> >
next prev parent reply other threads:[~2016-06-03 5:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 5:19 [PATCH] f2fs: fix to redirty page if fail to gc data page Chao Yu
2016-05-28 0:54 ` Chao Yu
2016-05-30 2:37 ` Jaegeuk Kim
2016-05-31 6:10 ` Chao Yu
2016-06-03 5:08 ` Jaegeuk Kim [this message]
2016-06-03 5:13 ` Chao Yu
2016-06-03 5:17 ` Jaegeuk Kim
2016-06-03 5:59 ` Chao Yu
2016-06-03 17:36 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603050858.GA24882@jaegeuk \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).