From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Bastien Nocera <hadess@hadess.net>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to report multitouch data
Date: Fri, 3 Jun 2016 11:38:55 +0200 [thread overview]
Message-ID: <20160603093855.GC6063@mail.corp.redhat.com> (raw)
In-Reply-To: <1464878415.1767.27.camel@linux.intel.com>
On Jun 02 2016 or thereabouts, Andy Shevchenko wrote:
> On Thu, 2016-06-02 at 16:11 +0200, Benjamin Tissoires wrote:
> > > > > >
> > On May 31 2016 or thereabouts, Andy Shevchenko wrote:
> > > On Tue, 2016-05-31 at 18:07 +0200, Benjamin Tissoires wrote:
> > > > On May 20 2016 or thereabouts, Benjamin Tissoires wrote:
> > > > > On May 13 2016 or thereabouts, Andy Shevchenko wrote:
> > > > > Would you mind sending me a hid-recorder[1] trace of the device
> > > > > while
> > > > > typing few keys and using the touchpad?
> > > >
>
> > OK, so it looks like your touchpad stays in the mouse emulation mode
> > for
> > some reasons. Did you do the recordings with hid-multitouch patched,
> > or
> > with plain hid-generic or an other one?
>
> I take linux-next + your two patches from this thread (+ some unrelated
> to HID patches).
OK. I think I know what happened:
- Microsoft forgot to put the Win 8 certification blob in this
particular device (of course, because Microsoft)
- we do not detect it as a Win 8 certified and do not set the
HID_QUIRK_NO_INIT_REPORTS flag
- your dmesg should show some error on plug, and then hid can't set the
input mode
- I can't add a "if win 8 then show the mouse collection" because your
device doesn't report itself as win 8 :)
Anyway, could you try applying this small diff after my 2 patches and
report if you now have a working touchpad?:
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index ac35731..e51a753 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -1379,6 +1379,10 @@ static const struct hid_device_id mt_devices[] = {
MT_USB_DEVICE(USB_VENDOR_ID_ILITEK,
USB_DEVICE_ID_ILITEK_MULTITOUCH) },
+ /* Microsoft */
+ { .driver_data = MT_CLS_WIN_8,
+ MT_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, 0x07cd) },
+
/* MosArt panels */
{ .driver_data = MT_CLS_CONFIDENCE_MINUS_ONE,
MT_USB_DEVICE(USB_VENDOR_ID_ASUS,
---
Cheers,
Benjamin
>
> >
> > After further thoughts, I think it should be acceptable to enable the
> > mouse collection for Win 8 certified devices. Touchscreens are not
> > supposed to expose such a mouse emulation, so that would mean that
> > only
> > touchpad will export one.
> >
>
> > I'll come with a patch by the end of the week (hopefully).
>
> Cc me and I will test 'em.
>
>
> --
> Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Intel Finland Oy
next prev parent reply other threads:[~2016-06-03 9:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 14:12 [PATCH 1/2] HID: input: rework HID_QUIRK_MULTI_INPUT Benjamin Tissoires
2016-05-12 14:12 ` [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to report multitouch data Benjamin Tissoires
2016-05-13 14:30 ` Andy Shevchenko
2016-05-13 14:49 ` Benjamin Tissoires
2016-05-13 16:09 ` Andy Shevchenko
2016-05-13 16:21 ` Benjamin Tissoires
2016-05-13 16:28 ` Andy Shevchenko
2016-05-20 7:58 ` Benjamin Tissoires
2016-05-31 16:07 ` Benjamin Tissoires
2016-05-31 17:56 ` Andy Shevchenko
2016-06-02 14:11 ` Benjamin Tissoires
2016-06-02 14:40 ` Andy Shevchenko
2016-06-03 9:38 ` Benjamin Tissoires [this message]
2016-06-03 11:59 ` Andy Shevchenko
2016-06-03 12:23 ` Benjamin Tissoires
2016-06-03 13:00 ` Andy Shevchenko
2016-06-03 13:32 ` Benjamin Tissoires
2016-06-13 12:32 ` Andy Shevchenko
2016-06-15 14:28 ` Benjamin Tissoires
2016-06-23 7:24 ` Andy Shevchenko
2016-05-17 17:47 ` Bastien Nocera
2016-06-23 1:12 ` Stephen J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603093855.GC6063@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hadess@hadess.net \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).