From: Pavel Machek <pavel@ucw.cz>
To: Eric Blake <eblake@redhat.com>, mpa@pengutronix.de
Cc: Pranay Srivastava <pranjas@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [Nbd] Fwd: [PATCH v4 02/18] nbd: fix checkpatch trailing space warning.
Date: Fri, 3 Jun 2016 18:50:55 +0200 [thread overview]
Message-ID: <20160603165055.GA11253@amd> (raw)
In-Reply-To: <573337B1.6030900@redhat.com>
On Wed 2016-05-11 07:46:25, Eric Blake wrote:
> On 05/11/2016 03:38 AM, Pranay Srivastava wrote:
>
> >
> > The series contained some checkpatch changes so I had included you as well.
> >
> >> know why you are sending them to me), but I know I do not accept patches
> >> without any changelog text at all in them, as that's just lazy.
> >
> > That should be per patch or can appear in a cover letter for the patches?
>
> Per patch. However, if it were me, I would not have split into quite so
> many patches. The mantra is one patch per one fix, but I think it is
> reasonable to state that "silence all checkpatch warnings" counts as one
> fix, rather than 16 separate fixes. If you DO consolidate the
> checkpatch changes into a single patch, then the commit message body
> should call out a bulleted list of all the changes you are making, as
> well as a justification why it is worth churning the entire file rather
> than just making smaller checkpatch fixes in just the areas that your
> other patches touch.
Unfortunately, Greg told him to split it like this. I also liked the
single patch more.
I wonder why mpa@pengutronix.de was not cc-ed on this series? Anyway,
the cleanups are so trivial they should just be applied.... No need to
spend huge time arguing.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2016-06-03 16:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 8:18 [PATCH v4 00/18] nbd: fixes for might_sleep warning, checkpatch warning and device wait Pranay Kr. Srivastava
2016-05-11 8:18 ` [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout Pranay Kr. Srivastava
2016-05-12 9:40 ` Markus Pargmann
2016-05-12 9:43 ` [PATCH] nbd: Move socket shutdown out of spinlock Markus Pargmann
2016-05-12 11:12 ` Pranay Srivastava
2016-05-12 12:43 ` Markus Pargmann
2016-05-12 15:08 ` Pranay Srivastava
2016-05-19 6:22 ` [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout Markus Pargmann
2016-05-19 20:35 ` Pranay Srivastava
2016-05-20 8:22 ` Markus Pargmann
2016-05-23 10:32 ` Pranay Srivastava
2016-05-25 17:15 ` Pranay Srivastava
2016-05-11 8:18 ` [PATCH v4 02/18] nbd: fix checkpatch trailing space warning Pranay Kr. Srivastava
2016-05-11 8:33 ` Greg KH
[not found] ` <CA+aCy1GKfNd+VXi6f9Nrz63wx4tOafPp4j8_vScPF+T=+YR41Q@mail.gmail.com>
2016-05-11 9:38 ` Fwd: " Pranay Srivastava
2016-05-11 13:46 ` [Nbd] " Eric Blake
2016-05-12 9:25 ` Markus Pargmann
2016-06-03 16:50 ` Pavel Machek [this message]
2016-05-11 8:18 ` [PATCH v4 03/18] nbd: fix checkpatch warning use linux/uaccess.h Pranay Kr. Srivastava
2016-05-11 8:18 ` [PATCH v4 04/18] nbd : fix checkpatch pointer declaration warning Pranay Kr. Srivastava
2016-05-11 8:18 ` [PATCH v4 05/18] nbd: fix checkpatch warning no newline after decleration Pranay Kr. Srivastava
2016-05-11 8:18 ` [PATCH v4 06/18] " Pranay Kr. Srivastava
2016-05-11 8:18 ` [PATCH v4 07/18] nbd: fix checkpatch split string warning Pranay Kr. Srivastava
2016-05-12 8:39 ` Markus Pargmann
2016-05-11 8:18 ` [PATCH v4 08/18] nbd : fix checkpatch line over 80 char warning Pranay Kr. Srivastava
2016-05-11 8:18 ` [PATCH v4 09/18] nbd: fix checkpatch trailing whitespace warning Pranay Kr. Srivastava
2016-05-11 8:18 ` [PATCH v4 10/18] " Pranay Kr. Srivastava
2016-05-11 8:18 ` [PATCH v4 11/18] nbd : fix checkpatch structure declaration braces on next line warning Pranay Kr. Srivastava
2016-05-11 8:18 ` [PATCH v4 12/18] nbd : fix checkpatch trailing whitespace warning Pranay Kr. Srivastava
2016-05-11 8:18 ` [PATCH v4 13/18] nbd : fix checkpatch printk warning Pranay Kr. Srivastava
2016-05-11 8:18 ` [PATCH v4 14/18] nbd: fix checkpatch no extra line after decleration warning Pranay Kr. Srivastava
2016-05-11 8:18 ` [PATCH v4 15/18] nbd: fix checkpatch printk warning to pr_info Pranay Kr. Srivastava
2016-05-11 8:18 ` [PATCH v4 16/18] nbd: fix checkpatch no new line after decleration warning Pranay Kr. Srivastava
2016-05-11 8:18 ` [PATCH v4 17/18] nbd: fix checkpatch printk warning to pr_info Pranay Kr. Srivastava
2016-05-11 8:18 ` [PATCH v4 18/18] make nbd device wait for its users in case of timeout Pranay Kr. Srivastava
2016-05-12 9:19 ` Markus Pargmann
2016-05-12 15:19 ` Pranay Srivastava
2016-05-19 6:36 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603165055.GA11253@amd \
--to=pavel@ucw.cz \
--cc=eblake@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=nbd-general@lists.sourceforge.net \
--cc=pranjas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).