From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932834AbcFCS5n (ORCPT <rfc822;w@1wt.eu>);
	Fri, 3 Jun 2016 14:57:43 -0400
Received: from foss.arm.com ([217.140.101.70]:54937 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752550AbcFCS5l (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 3 Jun 2016 14:57:41 -0400
Date: Fri, 3 Jun 2016 19:57:20 +0100
From: Mark Rutland <mark.rutland@arm.com>
To: Andrew Duggan <aduggan@synaptics.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Vincent Huang <vincent.huang@tw.synaptics.com>,
        Nick Dyer <nick.dyer@itdev.co.uk>, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/7] Input: synaptics-rmi4: Add dribble and palm gesture
 parameters to devicetree
Message-ID: <20160603185720.GA5204@leverpostej>
References: <1464979228-2497-1-git-send-email-aduggan@synaptics.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1464979228-2497-1-git-send-email-aduggan@synaptics.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 03, 2016 at 11:40:28AM -0700, Andrew Duggan wrote:
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
> ---
>  .../devicetree/bindings/input/rmi4/rmi_2d_sensor.txt       |  5 +++++
>  drivers/input/rmi4/rmi_2d_sensor.c                         | 14 ++++++++++++++
>  2 files changed, 19 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt b/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
> index f2c30c8..822df11 100644
> --- a/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
> +++ b/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
> @@ -37,6 +37,11 @@ Optional Properties:
>  				disable reporing absolute position data.
>  - syna,rezero-wait-ms: Time in miliseconds to wait after issuing a rezero
>  				command.
> +- syna,dribble: Control reporting of dribble packets. Values are 0 for
> +		default, 1 for explicitly disable, 2 for explicitly enable.

This sounds like a driver option one might choose at runtime, not a
fixed hardware/integration property.

Why does this belong in the DT?

> +- syna,palm_detect: Control reporting of the palm detect gesture. Values
> +			are 0 for default, 1 for explicitly disable, 2 for
> +			explicitly enable.

Likewise, same question here.

Additionally, please use '-', not '_' in property names.

Thanks,
Mark.