From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933025AbcFCVGU (ORCPT ); Fri, 3 Jun 2016 17:06:20 -0400 Received: from mail.kernel.org ([198.145.29.136]:60664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933002AbcFCVGH (ORCPT ); Fri, 3 Jun 2016 17:06:07 -0400 Date: Fri, 3 Jun 2016 18:06:02 -0300 From: Arnaldo Carvalho de Melo To: He Kuang Cc: Jiri Olsa , peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 00/14] Add support for remote unwind Message-ID: <20160603210602.GA3095@kernel.org> References: <1464924803-22214-1-git-send-email-hekuang@huawei.com> <20160603070629.GB23006@krava> <20160603194205.GB27920@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160603194205.GB27920@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Jun 03, 2016 at 04:42:05PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Jun 03, 2016 at 09:06:29AM +0200, Jiri Olsa escreveu: > > On Fri, Jun 03, 2016 at 03:33:09AM +0000, He Kuang wrote: > > > v9: > > > - Change function unwind__register_ops() to static. > > > - Move up unwind__prepare_access() in thread__insert_map() and save > > > map_groups__remove() call. > > > - Enclose multiple line if/else into braces. > > > - Fix miss modified function declaration for unwind__prepare_access() > > > in patch 10. > > > for patchset: > > > Acked-by: Jiri Olsa > > Thanks, applied, build testing. Build tested went ok, but then 'perf top' crashes: [root@jouet ~]# perf top perf: Segmentation fault -------- backtrace -------- perf[0x55591b] /lib64/libc.so.6(+0x34ab0)[0x7f38ad9c1ab0] perf(normalize_arch+0x27)[0x534797] perf(unwind__prepare_access+0xbb)[0x52b15b] perf(thread__insert_map+0x27)[0x4d4837] perf(machine__process_mmap2_event+0xd7)[0x4ca187] perf(perf_event__synthesize_mmap_events+0x3e2)[0x491b32] perf(perf_event__synthesize_threads+0x445)[0x492635] perf(cmd_top+0xee0)[0x442f50] perf[0x486a91] perf(main+0x6ee)[0x42485e] /lib64/libc.so.6(__libc_start_main+0xf0)[0x7f38ad9ad580] perf(_start+0x29)[0x424949] [0x0] [root@jouet ~]# And I bet that 'perf trace' will too, lemme see, well, it crashes even more spetacularly, but that is the topic of another bug report, will send soon. Anyway, please try your patchkit with 'perf top' and 'perf trace', as both don't use perf.data files, i.e. they work 'live', so probably things that you touch in normalize_arch() are not initialized and need to be setup. - Arnaldo