From: Stephen Boyd <sboyd@codeaurora.org>
To: Andy Gross <andy.gross@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
devicetree@vger.kernel.org, jilai wang <jilaiw@codeaurora.org>
Subject: Re: [Patch v6 02/10] firmware: qcom: scm: Convert SCM to platform driver
Date: Fri, 3 Jun 2016 17:03:43 -0700 [thread overview]
Message-ID: <20160604000343.GW28218@codeaurora.org> (raw)
In-Reply-To: <1464996330-16952-3-git-send-email-andy.gross@linaro.org>
On 06/03, Andy Gross wrote:
> This patch converts the Qualcomm SCM firmware driver into a platform
> driver. It also adds clock management for firmware calls which require
> clocks to be enabled during the duration of their execution. Rate
> setting of the core clock is also in place for higher performance.
>
> Signed-off-by: Andy Gross <andy.gross@linaro.org>
> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
> +
> +static int __init qcom_scm_init(void)
> +{
> + struct device_node *np, *fw_np;
> + int ret;
> +
> + fw_np = of_find_node_by_name(NULL, "firmware");
> +
> + if (!fw_np)
> + return -ENODEV;
> +
> + np = of_find_matching_node(fw_np, qcom_scm_dt_match);
> +
> + if (!np) {
> + of_node_put(fw_np);
> + return -ENODEV;
> + }
> +
> + of_node_put(np);
> +
> + ret = of_platform_populate(fw_np, qcom_scm_dt_match, NULL, NULL);
> +
> + of_node_put(fw_np);
> +
> + if (ret)
> + return ret;
> +
> + return platform_driver_register(&qcom_scm_driver);
> +}
There are lots of newlines in this function, but that's a style nitpick.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-06-04 0:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 23:25 [Patch v6 00/10] Qualcomm SCM Rework Andy Gross
2016-06-03 23:25 ` [Patch v6 01/10] dt/bindings: firmware: Add Qualcomm SCM binding Andy Gross
2016-06-03 23:25 ` [Patch v6 02/10] firmware: qcom: scm: Convert SCM to platform driver Andy Gross
2016-06-04 0:03 ` Stephen Boyd [this message]
2016-06-03 23:25 ` [Patch v6 03/10] firmware: qcom: scm: Use atomic SCM for cold boot Andy Gross
2016-06-03 23:25 ` [Patch v6 04/10] firmware: qcom: scm: Generalize shared error map Andy Gross
2016-06-03 23:25 ` [Patch v6 05/10] firmware: qcom: scm: Convert to streaming DMA APIS Andy Gross
2016-06-04 0:04 ` Stephen Boyd
2016-06-03 23:25 ` [Patch v6 06/10] firmware: qcom: scm: Add support for ARM64 SoCs Andy Gross
2016-06-04 0:01 ` Stephen Boyd
2016-06-03 23:25 ` [Patch v6 07/10] dts: qcom: apq8084: Add SCM firmware node Andy Gross
2016-06-03 23:25 ` [Patch v6 08/10] arm64: dts: msm8916: " Andy Gross
2016-06-03 23:25 ` [Patch v6 09/10] dts: qcom: msm8974: " Andy Gross
2016-06-04 0:01 ` Stephen Boyd
2016-06-03 23:25 ` [Patch v6 10/10] dts: qcom: apq8064: " Andy Gross
2016-06-04 0:01 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160604000343.GW28218@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jilaiw@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).