From: Clemens Gruber <clemens.gruber@pqgruber.com>
To: Eric Nelson <eric@nelint.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision
Date: Sat, 4 Jun 2016 11:03:24 +0200 [thread overview]
Message-ID: <20160604090324.GA867@archie.localdomain> (raw)
In-Reply-To: <575264A4.2070709@nelint.com>
Hi Eric,
On Sat, Jun 04, 2016 at 07:18:28AM +0200, Eric Nelson wrote:
> AFAIK, the SGTL5000 versions < 0x11 are like Sasquatch: I've seen
> no real proof of their existence. I tried to chase down when this
> code was introduced, but it seems to have been around since
> the dawn of the driver.
>
> Clemens, if you're really trying to control an external regulator,
> I think you'll need lots more than this patch. There are some
> fundamental flaws in regulator handling and I put together some
> RFC patches to address them in February 2015:
> http://mailman.alsa-project.org/pipermail/alsa-devel/2015-February/thread.html#88353
>
> The long and short of it is that at least one of the regulators
> would need to be initialized before the SGTL5000 probes.
Thank you very much for your input on this. So we can assume that no
user of the sgtl5000 is controlling an external VDDD regulator, because
this does not work without your patch series from Februar 2015.
As far as not enabling the internal LDO when using external VDDD and
avoiding the misleading "Using internal LDO..." message at boot, do you
think my patch would be OK?
Regards,
Clemens
next prev parent reply other threads:[~2016-06-04 9:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 12:47 [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision Clemens Gruber
2016-06-02 15:48 ` Fabio Estevam
2016-06-02 16:56 ` Mark Brown
2016-06-03 15:52 ` Clemens Gruber
2016-06-03 16:23 ` Eric Nelson
2016-06-04 5:18 ` Eric Nelson
2016-06-04 9:03 ` Clemens Gruber [this message]
[not found] ` <20160604171525.GA29266@archie.localdomain>
2016-06-05 23:16 ` [alsa-devel] " Clemens Gruber
2016-06-06 1:22 ` Fabio Estevam
2016-06-06 16:45 ` Clemens Gruber
2016-06-06 17:10 ` Fabio Estevam
2016-06-06 17:55 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2016-05-31 19:11 Clemens Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160604090324.GA867@archie.localdomain \
--to=clemens.gruber@pqgruber.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=eric@nelint.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).