From: "Michael Büsch" <m@bues.ch>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
b43-dev@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] b43: Remove unused phy_a code
Date: Sat, 4 Jun 2016 10:01:40 +0200 [thread overview]
Message-ID: <20160604100140.43ca7621@wiggum> (raw)
In-Reply-To: <1465013512-30301-1-git-send-email-linux@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]
On Fri, 3 Jun 2016 21:11:51 -0700
Guenter Roeck <linux@roeck-us.net> wrote:
> +static void __b43_phy_initg(struct b43_wldev *dev)
> +{
> + struct b43_phy *phy = &dev->phy;
> +
> + might_sleep();
> +
> + if (phy->rev >= 6) {
> + if (b43_phy_read(dev, B43_PHY_ENCORE) & B43_PHY_ENCORE_EN)
> + b43_phy_set(dev, B43_PHY_ENCORE, 0x0010);
> + else
> + b43_phy_mask(dev, B43_PHY_ENCORE, ~0x1010);
> + }
> +
> + b43_wa_all(dev);
> +
> + if (dev->dev->bus_sprom->boardflags_lo & B43_BFL_PACTRL)
> + b43_phy_maskset(dev, B43_PHY_OFDM(0x6E), 0xE000, 0x3CF);
> +}
> +
> static void b43_phy_initg(struct b43_wldev *dev)
> {
> struct b43_phy *phy = &dev->phy;
> @@ -1999,7 +2019,7 @@ static void b43_phy_initg(struct b43_wldev *dev)
> b43_phy_initb6(dev);
>
> if (phy->rev >= 2 || phy->gmode)
> - b43_phy_inita(dev);
> + __b43_phy_initg(dev);
This actually is correctly called inita(), because there are A-phy parts
in the G-phy.
So I wasn't 100% correct saying that _all_ a-phy code is unused.
I'm Ok with moving that into the g-phy file though. But don't rename it.
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-06-04 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 4:11 [PATCH v2 1/2] b43: Remove unused phy_a code Guenter Roeck
2016-06-04 4:11 ` [PATCH v2 2/2] b43: Completely remove support for phy_a Guenter Roeck
2016-06-04 8:01 ` Michael Büsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160604100140.43ca7621@wiggum \
--to=m@bues.ch \
--cc=b43-dev@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).