From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750866AbcFDDkl (ORCPT <rfc822;w@1wt.eu>);
	Fri, 3 Jun 2016 23:40:41 -0400
Received: from mail.kernel.org ([198.145.29.136]:45157 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750726AbcFDDkk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 3 Jun 2016 23:40:40 -0400
Date: Sat, 4 Jun 2016 12:40:32 +0900
From: Masami Hiramatsu <mhiramat@kernel.org>
To: David Long <dave.long@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
        Huang Shijie <shijie.huang@arm.com>, James Morse <james.morse@arm.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Pratyush Anand <panand@redhat.com>,
        Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com>,
        Will Deacon <will.deacon@arm.com>, William Cohen <wcohen@redhat.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Steve Capper <steve.capper@linaro.org>,
        Li Bin <huawei.libin@huawei.com>,
        Adam Buchbinder <adam.buchbinder@gmail.com>,
        Alex =?UTF-8?B?QmVubsOpZQ==?= <alex.bennee@linaro.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Christoffer Dall <christoffer.dall@linaro.org>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Dave P Martin <Dave.Martin@arm.com>,
        Jens Wiklander <jens.wiklander@linaro.org>,
        Jisheng Zhang <jszhang@marvell.com>,
        John Blackwood <john.blackwood@ccur.com>,
        Mark Rutland <mark.rutland@arm.com>, Petr Mladek <pmladek@suse.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Vladimir Murzin <Vladimir.Murzin@arm.com>,
        Yang Shi <yang.shi@linaro.org>, Zi Shen Lim <zlim.lnx@gmail.com>,
        yalin wang <yalin.wang2010@gmail.com>, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v13 04/10] arm64: Blacklist non-kprobe-able symbol
Message-Id: <20160604124032.94ac1bb76fde6c661e1a47a5@kernel.org>
In-Reply-To: <1464924384-15269-5-git-send-email-dave.long@linaro.org>
References: <1464924384-15269-1-git-send-email-dave.long@linaro.org>
	<1464924384-15269-5-git-send-email-dave.long@linaro.org>
X-Mailer: Sylpheed 3.4.3 (GTK+ 2.24.28; x86_64-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi David,

On Thu,  2 Jun 2016 23:26:18 -0400
David Long <dave.long@linaro.org> wrote:

> From: Pratyush Anand <panand@redhat.com>
> 
> Add all function symbols which are called from do_debug_exception under
> NOKPROBE_SYMBOL, as they can not kprobed.

I see, but this patch should be applied after kprobes
are implemented on arm64.

And also, I have a comment below.

> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 5954881..4359ca8 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -563,6 +563,7 @@ asmlinkage void __exception do_sp_pc_abort(unsigned long addr,
>  	info.si_addr  = (void __user *)addr;
>  	arm64_notify_die("Oops - SP/PC alignment exception", regs, &info, esr);
>  }
> +NOKPROBE_SYMBOL(do_debug_exception)

This seems at wrong place. Please correct it in this patch.

Thank you,

-- 
Masami Hiramatsu <mhiramat@kernel.org>