From: Peter Zijlstra <peterz@infradead.org>
To: Yuyang Du <yuyang.du@intel.com>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
bsegall@google.com, pjt@google.com, morten.rasmussen@arm.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com
Subject: Re: [PATCH v4 3/5] sched/fair: Skip detach sched avgs for new task when changing task groups
Date: Mon, 6 Jun 2016 11:58:40 +0200 [thread overview]
Message-ID: <20160606095840.GB30909@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1465172441-27727-4-git-send-email-yuyang.du@intel.com>
On Mon, Jun 06, 2016 at 08:20:39AM +0800, Yuyang Du wrote:
> +static void task_move_group_fair(struct task_struct *p, bool fork)
> {
> - detach_task_cfs_rq(p);
> + /*
> + * Newly forked task should not be removed from any cfs_rq
That's a pointless comment; that's exactly what the code _does_.
Comments should explain the code, not restate it.
So a comment like:
* Newly forked tasks are not attached yet.
Is entirely more useful.
> + */
> + if (!fork)
> + detach_task_cfs_rq(p);
> set_task_rq(p, task_cpu(p));
> attach_task_cfs_rq(p);
> /*
next prev parent reply other threads:[~2016-06-06 9:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 0:20 [PATCH v4 0/5] sched/fair: Fix attach and detach sched avgs for task group change or sched class change Yuyang Du
2016-06-06 0:20 ` [PATCH v4 1/5] sched/fair: Clean up attach_entity_load_avg() Yuyang Du
2016-06-06 13:30 ` Matt Fleming
2016-06-06 13:40 ` Vincent Guittot
2016-06-06 14:06 ` Matt Fleming
2016-06-06 14:27 ` Peter Zijlstra
2016-06-06 0:20 ` [PATCH v4 2/5] sched/fair: Fix attaching task sched avgs twice when switching to fair or changing task group Yuyang Du
2016-06-06 9:54 ` Peter Zijlstra
2016-06-06 19:38 ` Yuyang Du
2016-06-06 12:32 ` Vincent Guittot
2016-06-06 19:05 ` Yuyang Du
2016-06-07 8:09 ` Vincent Guittot
2016-06-07 18:16 ` Yuyang Du
2016-06-06 0:20 ` [PATCH v4 3/5] sched/fair: Skip detach sched avgs for new task when changing task groups Yuyang Du
2016-06-06 9:58 ` Peter Zijlstra [this message]
2016-06-06 14:03 ` Matt Fleming
2016-06-06 19:15 ` Yuyang Du
2016-06-06 0:20 ` [PATCH v4 4/5] sched/fair: Move load and util avgs from wake_up_new_task() to sched_fork() Yuyang Du
2016-06-06 0:20 ` [PATCH v4 5/5] sched/fair: Add inline to detach_entity_load_evg() Yuyang Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606095840.GB30909@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=pjt@google.com \
--cc=vincent.guittot@linaro.org \
--cc=yuyang.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).