From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Bill Mills <wmills@ti.com>
Cc: mark.rutland@arm.com, t-kristo@ti.com, ssantosh@kernel.org,
catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, r-woodruff2@ti.com
Subject: Re: [RFC v2 1/4] ARM: mm: add early page table attribute modification ability
Date: Mon, 6 Jun 2016 13:18:12 +0100 [thread overview]
Message-ID: <20160606121812.GK1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1465183229-24147-2-git-send-email-wmills@ti.com>
On Sun, Jun 05, 2016 at 11:20:26PM -0400, Bill Mills wrote:
> Allow early-init to specify modifications to be made to the boot time page
> table. Any modifications specified will be done with MMU off at the same
> time that any Phy<->Virt fixup is done.
I think this is rather over-engineered - do we need to support multiple
different fixups to the page tables like this?
Given how this has grown, I think it would be better to duplicate the
existing swapper_pg_dir, modify the new copy, and then have the
pv-fixup-asm code merely copy the new to the old with the MMU off.
That way, the only two things that the assembly code has to do is to
deal with the page table update, and updating the TTBR registers.
Most of the complexity can then be kept in the C code.
I think we also need to modify the TTBCR to match the sharability of
memory - currently, TTB walks will be inner sharable, but my
understanding is that if we switch memory to be outer sharable, we
also need to update the TTB walks to match.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-06-06 12:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 3:20 [RFC v2 0/4] ARM LPAE Outer Shared v2 Bill Mills
2016-06-06 3:20 ` [RFC v2 1/4] ARM: mm: add early page table attribute modification ability Bill Mills
2016-06-06 12:18 ` Russell King - ARM Linux [this message]
2016-06-06 12:31 ` William Mills
2016-06-06 3:20 ` [RFC v2 2/4] ARM: mm: Add LPAE support for outer shared Bill Mills
2016-06-06 3:20 ` [RFC v2 3/4] ARM: mm: add inner/outer sharing value command line Bill Mills
2016-06-06 3:20 ` [RFC v2 4/4] ARM: keystone: dma-coherent with safe fallback Bill Mills
2016-06-06 8:56 ` Mark Rutland
2016-06-06 9:09 ` Arnd Bergmann
2016-06-06 11:42 ` Mark Rutland
2016-06-06 12:37 ` Arnd Bergmann
2016-06-06 12:50 ` William Mills
2016-06-06 16:18 ` Santosh Shilimkar
2016-06-06 11:43 ` Russell King - ARM Linux
2016-06-06 11:59 ` Mark Rutland
2016-06-06 12:19 ` William Mills
2016-06-06 12:32 ` Russell King - ARM Linux
2016-06-06 16:28 ` Santosh Shilimkar
2016-06-07 10:01 ` Mark Rutland
2016-06-07 12:32 ` Russell King - ARM Linux
2016-06-07 12:55 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606121812.GK1041@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=r-woodruff2@ti.com \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=wmills@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).