From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752315AbcFFMrM (ORCPT ); Mon, 6 Jun 2016 08:47:12 -0400 Received: from foss.arm.com ([217.140.101.70]:36246 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752227AbcFFMrG (ORCPT ); Mon, 6 Jun 2016 08:47:06 -0400 Date: Mon, 6 Jun 2016 13:47:00 +0100 From: Javi Merino To: Caesar Wang Cc: edubezval@gmail.com, linux-pm@vger.kernel.org, Heiko Stuebner , dianders@chromium.org, briannorris@google.com, smbarber@google.com, linux-rockchip@lists.infradead.org, cf@rock-chips.com, huangtao@rock-chips.com, dmitry.torokhov@gmail.com, peter@piie.net, Sascha Hauer , Zhang Rui , Jonathan Corbet , Andy Champ , Laxman Dewangan , Durgadoss R , Ni Wade , Leo Yan , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/5] thermal: Add support for hardware-tracked trip points Message-ID: <20160606124700.GB2897@e104805> References: <1465213489-14898-1-git-send-email-wxt@rock-chips.com> <1465213489-14898-2-git-send-email-wxt@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1465213489-14898-2-git-send-email-wxt@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2016 at 07:44:45PM +0800, Caesar Wang wrote: > From: Sascha Hauer > > This adds support for hardware-tracked trip points to the device tree > thermal sensor framework. > > The framework supports an arbitrary number of trip points. Whenever > the current temperature is updated, the trip points immediately > below and above the current temperature are found. A .set_trips > callback is then called with the temperatures. If there is no trip > point above or below the current temperature, the passed trip > temperature will be -INT_MAX or INT_MAX respectively. In this callback, > the driver should program the hardware such that it is notified > when either of these trip points are triggered. When a trip point > is triggered, the driver should call `thermal_zone_device_update' > for the respective thermal zone. This will cause the trip points > to be updated again. > > If .set_trips is not implemented, the framework behaves as before. > > This patch is based on an earlier version from Mikko Perttunen > > > Signed-off-by: Sascha Hauer > Signed-off-by: Caesar Wang > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc: linux-pm@vger.kernel.org > > --- > > Changes in v5: > - add the lock for thermal_zone_set_trips function. Looks good to me! Reviewed-by: Javi Merino > - change based on next kernel. > > Changes in v4: > - Missing the lock added in v3. > > Changes in v3: > - as Javi comments on https://patchwork.kernel.org/patch/9001281/. > - add the lock for preventing the called from multi placce > - add the note for pre_low/high_trip. > > Changes in v2: > - update the sysfs-api.txt for set_trips. > > Documentation/thermal/sysfs-api.txt | 7 +++++ > drivers/thermal/thermal_core.c | 54 +++++++++++++++++++++++++++++++++++++ > drivers/thermal/thermal_sysfs.c | 3 +++ > include/linux/thermal.h | 10 +++++++ > 4 files changed, 74 insertions(+) >