From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751951AbcFFPcL (ORCPT ); Mon, 6 Jun 2016 11:32:11 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:35186 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbcFFPcB (ORCPT ); Mon, 6 Jun 2016 11:32:01 -0400 Date: Mon, 6 Jun 2016 16:32:31 +0100 From: Lee Jones To: Boris Brezillon Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, kernel@stlinux.com, ajitpal.singh@st.com, thierry.reding@gmail.com, maxime.coquelin@st.com Subject: Re: [PATCH v2 00/11] pwm: Add support for PWM Capture Message-ID: <20160606153231.GE1525@dell> References: <1461320295-20414-1-git-send-email-lee.jones@linaro.org> <20160429094010.6bfb131c@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160429094010.6bfb131c@bbrezillon> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Apr 2016, Boris Brezillon wrote: > Hi Lee, > > On Fri, 22 Apr 2016 11:18:04 +0100 > Lee Jones wrote: > > > The first part of this set extends the current PWM API to allow external > > code to request a PWM Capture. Subsequent patches then make use of the > > new API by providing a userspace offering via /sysfs. The final part of > > the set supplies PWM Capture functionality into the already existing STi > > PWM driver. > > Is there a reason you decided to not put this driver in IIO? IMHO, it > would be more appropriate to make your PWM device an MFD that can either > bind to the PWM or the capture driver. > And BTW, IIO already has a sysfs interface (you may have to extend the > API to support your type of capture though). Multi-Function Device drivers can only be justified if the IP contained does not and can not live in a single subsystem. The IP which controls both PWM-in and PWM-out in this device is the same. I can't fathom a sane reason why you would wish to separate this functionality over multiple subsystems. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog