linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
	Andi Kleen <andi@firstfloor.org>,
	linux-kernel@vger.kernel.org, jolsa@kernel.org
Subject: Re: [PATCH] perf test: Ignore .scale and other special files
Date: Mon, 6 Jun 2016 09:31:16 -0700	[thread overview]
Message-ID: <20160606163116.GC9646@tassilo.jf.intel.com> (raw)
In-Reply-To: <20160606150945.GE31477@kernel.org>

> [root@jouet ~]# perf stat -e topdown-total-slots:u,cpu/event=topdown-total-slots/u usleep 1
> event syntax error: 'topdown-total-slots:u,cpu/event=topdown-total-slots/u'
>                             \___ parser error
> Run 'perf list' for a list of valid events
> 
>  Usage: perf stat [<options>] [<command>]
> 
>     -e, --event <event>   event selector. use 'perf list' to list available events
> [root@jouet ~]#
> 
> that it fails, Jiri, probably something obvious to you? :-)

Works for me here

./perf stat -e topdown-total-slots:u,cpu/event=topdown-total-slots/u sleep 1

 Performance counter stats for 'sleep 1':

           515,204      topdown-total-slots:u                                       
           514,712      cpu/event=topdown-total-slots/u                                   

       1.001438114 seconds time elapsed


Did you perhaps miss this hunk?

--- a/tools/perf/util/parse-events.l
+++ b/tools/perf/util/parse-events.l
@@ -259,6 +259,7 @@ cycles-ct                                   { return str(yyscanner, PE_KERNEL_PMU_EVENT); }
 cycles-t                                       { return str(yyscanner, PE_KERNEL_PMU_EVENT); }
 mem-loads                                      { return str(yyscanner, PE_KERNEL_PMU_EVENT); }
 mem-stores                                     { return str(yyscanner, PE_KERNEL_PMU_EVENT); }
+topdown-[a-z-]+                                        { return str(yyscanner, PE_KERN

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only

  reply	other threads:[~2016-06-06 16:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 14:36 [PATCH] perf test: Ignore .scale and other special files Andi Kleen
2016-06-06 14:51 ` Arnaldo Carvalho de Melo
2016-06-06 14:54   ` Arnaldo Carvalho de Melo
2016-06-06 15:09     ` Arnaldo Carvalho de Melo
2016-06-06 16:31       ` Andi Kleen [this message]
2016-06-06 19:56         ` Arnaldo Carvalho de Melo
2016-06-08  8:38 ` [tip:perf/core] " tip-bot for Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160606163116.GC9646@tassilo.jf.intel.com \
    --to=ak@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=arnaldo.melo@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).