From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751892AbcFFRCq (ORCPT <rfc822;w@1wt.eu>);
	Mon, 6 Jun 2016 13:02:46 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:35652 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751105AbcFFRCp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 6 Jun 2016 13:02:45 -0400
Date: Mon, 6 Jun 2016 18:02:42 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Zhao Lei <zhaolei@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Mateusz Guzik <mguzik@redhat.com>,
        Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 1/3] Save dump_root into pid_namespace
Message-ID: <20160606170242.GD14480@ZenIV.linux.org.uk>
References: <cover.1465214472.git.zhaolei@cn.fujitsu.com>
 <80f929b266dd3ac6ad5f5d9955f393b0f1f8120f.1465214472.git.zhaolei@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <80f929b266dd3ac6ad5f5d9955f393b0f1f8120f.1465214472.git.zhaolei@cn.fujitsu.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 06, 2016 at 08:02:08PM +0800, Zhao Lei wrote:
> +	spin_lock(&pid_ns->root_for_dump_lock);
> +
> +	if (pid_ns->root_for_dump.mnt)
> +		path_put(&pid_ns->root_for_dump);

NAK, for obvious reasons - don't do blocking operations under spinlocks,
for starters.