From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752740AbcFGAWl (ORCPT ); Mon, 6 Jun 2016 20:22:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57616 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbcFGAWk (ORCPT ); Mon, 6 Jun 2016 20:22:40 -0400 Date: Tue, 7 Jun 2016 01:20:08 +0200 From: Oleg Nesterov To: David Rientjes Cc: Michal Hocko , linux-mm@kvack.org, Tetsuo Handa , Vladimir Davydov , Andrew Morton , LKML , Michal Hocko Subject: Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm Message-ID: <20160606232007.GA624@redhat.com> References: <1464945404-30157-1-git-send-email-mhocko@kernel.org> <1464945404-30157-7-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 07 Jun 2016 00:22:39 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06, David Rientjes wrote: > > > There is a potential race where we kill the oom disabled task which is > > highly unlikely but possible. It would happen if __set_oom_adj raced > > with select_bad_process and then it is OK to consider the old value or > > with fork when it should be acceptable as well. > > Let's add a little note to the log so that people would tell us that > > this really happens in the real life and it matters. > > > > We cannot kill oom disabled processes at all, little race or otherwise. But this change doesn't really make it worse? Oleg.