[PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

[PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

[Yong Li]

From: Yong Li <sdliyong@gmail.com>

Without this patch, I2C-1 is missing on beaglebone black boards

Signed-off-by: Yong Li <sdliyong@gmail.com>
---
 arch/arm/boot/dts/am335x-boneblack.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts
index 55c0e95..7eee5c4 100644
--- a/arch/arm/boot/dts/am335x-boneblack.dts
+++ b/arch/arm/boot/dts/am335x-boneblack.dts
@@ -64,6 +64,13 @@
 			AM33XX_IOPAD(0x9b0, PIN_OUTPUT_PULLDOWN | MUX_MODE3)	/* xdma_event_intr0 */
 		>;
 	};
+
+	i2c1_pins: pinmux_i2c1_pins {
+		pinctrl-single,pins = <
+			AM33XX_IOPAD(0x958, PIN_INPUT_PULLUP | MUX_MODE2)       /* spi0_d1.i2c1_sda */
+			AM33XX_IOPAD(0x95c, PIN_INPUT_PULLUP | MUX_MODE2)       /* spi0_cs0.i2c1_scl */
+		>;
+	};
 };
 
 &lcdc {
@@ -91,6 +98,14 @@
 	};
 };
 
+&i2c1 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&i2c2_pins>;
+
+       status = "okay";
+       clock-frequency = <100000>;
+};
+
 &rtc {
 	system-power-controller;
 };
-- 
2.7.4

Re: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

[Tony Lindgren]

* Robert Nelson <robertcnelson@gmail.com> [160602 10:39]:
> On Thu, Jun 2, 2016 at 2:41 AM, Yong Li <yong.b.li@intel.com> wrote:
> 
> > From: Yong Li <sdliyong@gmail.com>
> >
> > Without this patch, I2C-1 is missing on beaglebone black boards
> >
> > Signed-off-by: Yong Li <sdliyong@gmail.com>
> > ---
> >  arch/arm/boot/dts/am335x-boneblack.dts | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >
> 
> 
> This is also 'common' for the white/green, if your really going to push
> this, please add it to:
> 
> am335x-bone-common.dtsi

But isn't this exposed on the cape pins? So the use can be
whatever for these pins?

Tony

Re: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

[Robert Nelson]

On Thu, Jun 2, 2016 at 12:39 PM, Tony Lindgren <tony@atomide.com> wrote:
>
> * Robert Nelson <robertcnelson@gmail.com> [160602 10:39]:
> > On Thu, Jun 2, 2016 at 2:41 AM, Yong Li <yong.b.li@intel.com> wrote:
> >
> > > From: Yong Li <sdliyong@gmail.com>
> > >
> > > Without this patch, I2C-1 is missing on beaglebone black boards
> > >
> > > Signed-off-by: Yong Li <sdliyong@gmail.com>
> > > ---
> > >  arch/arm/boot/dts/am335x-boneblack.dts | 15 +++++++++++++++
> > >  1 file changed, 15 insertions(+)
> > >
> >
> >
> > This is also 'common' for the white/green, if your really going to push
> > this, please add it to:
> >
> > am335x-bone-common.dtsi
>
> But isn't this exposed on the cape pins? So the use can be
> whatever for these pins?

That is correct, "i2c1" is on the cape connector, with no primary
function defined.

Currently on mainline, the board and cape eeprom i2c bus's are enabled.

i2c0 = board eeprom
i2c2 = 'cape' eeprom

personally, nak by me to add i2c1 by default, should use overlay's to enable it.

Regards,

-- 
Robert Nelson
https://rcn-ee.com/

Re: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

[Tony Lindgren]

* Robert Nelson <robertcnelson@gmail.com> [160602 10:48]:
> On Thu, Jun 2, 2016 at 12:39 PM, Tony Lindgren <tony@atomide.com> wrote:
> >
> > * Robert Nelson <robertcnelson@gmail.com> [160602 10:39]:
> > > On Thu, Jun 2, 2016 at 2:41 AM, Yong Li <yong.b.li@intel.com> wrote:
> > >
> > > > From: Yong Li <sdliyong@gmail.com>
> > > >
> > > > Without this patch, I2C-1 is missing on beaglebone black boards
> > > >
> > > > Signed-off-by: Yong Li <sdliyong@gmail.com>
> > > > ---
> > > >  arch/arm/boot/dts/am335x-boneblack.dts | 15 +++++++++++++++
> > > >  1 file changed, 15 insertions(+)
> > > >
> > >
> > >
> > > This is also 'common' for the white/green, if your really going to push
> > > this, please add it to:
> > >
> > > am335x-bone-common.dtsi
> >
> > But isn't this exposed on the cape pins? So the use can be
> > whatever for these pins?
> 
> That is correct, "i2c1" is on the cape connector, with no primary
> function defined.
> 
> Currently on mainline, the board and cape eeprom i2c bus's are enabled.
> 
> i2c0 = board eeprom
> i2c2 = 'cape' eeprom
> 
> personally, nak by me to add i2c1 by default, should use overlay's to enable it.

Yes sounds like the best we can do is define it but set it with
status = "disabled" for now.

Regards,

Tony

RE: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

[Li, Yong B]

Hi Tony,

I can submit a V2 version about the "disabled", or just drop this patch?

Thanks,
Yong
-----Original Message-----
From: Tony Lindgren [mailto:tony@atomide.com] 
Sent: Friday, June 3, 2016 1:57 AM
To: Robert Nelson <robertcnelson@gmail.com>
Cc: Li, Yong B <yong.b.li@intel.com>; Benoit Cousson <bcousson@baylibre.com>; Rob Herring <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>; Mark Rutland <mark.rutland@arm.com>; Ian Campbell <ijc+devicetree@hellion.org.uk>; Kumar Gala <galak@codeaurora.org>; Russell King <linux@arm.linux.org.uk>; linux-omap@vger.kernel.org; devicetree <devicetree@vger.kernel.org>; linux-arm-kernel@lists.infradead.org; linux kernel <linux-kernel@vger.kernel.org>; sdliyong@gmail.com
Subject: Re: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

* Robert Nelson <robertcnelson@gmail.com> [160602 10:48]:
> On Thu, Jun 2, 2016 at 12:39 PM, Tony Lindgren <tony@atomide.com> wrote:
> >
> > * Robert Nelson <robertcnelson@gmail.com> [160602 10:39]:
> > > On Thu, Jun 2, 2016 at 2:41 AM, Yong Li <yong.b.li@intel.com> wrote:
> > >
> > > > From: Yong Li <sdliyong@gmail.com>
> > > >
> > > > Without this patch, I2C-1 is missing on beaglebone black boards
> > > >
> > > > Signed-off-by: Yong Li <sdliyong@gmail.com>
> > > > ---
> > > >  arch/arm/boot/dts/am335x-boneblack.dts | 15 +++++++++++++++
> > > >  1 file changed, 15 insertions(+)
> > > >
> > >
> > >
> > > This is also 'common' for the white/green, if your really going to 
> > > push this, please add it to:
> > >
> > > am335x-bone-common.dtsi
> >
> > But isn't this exposed on the cape pins? So the use can be whatever 
> > for these pins?
> 
> That is correct, "i2c1" is on the cape connector, with no primary 
> function defined.
> 
> Currently on mainline, the board and cape eeprom i2c bus's are enabled.
> 
> i2c0 = board eeprom
> i2c2 = 'cape' eeprom
> 
> personally, nak by me to add i2c1 by default, should use overlay's to enable it.

Yes sounds like the best we can do is define it but set it with status = "disabled" for now.

Regards,

Tony

Re: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

[Tony Lindgren]

* Li, Yong B <yong.b.li@intel.com> [160602 22:49]:
> Hi Tony,
> 
> I can submit a V2 version about the "disabled", or just drop this patch?

Probably best to wait on this one until we know how it can be
enabled without manually editing the dts file. I'm still hoping
u-boot could enable it based on some environment variable..

Regards,

Tony

RE: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

[Li, Yong B]

Thanks Tony.

I checked the DTS/overlays using linux-yocto-4.1 kernel(Ostro OS). It seems to me that the kernel/u-boot do not include the latest overlay support patch. And I also tested the latest Debian 8.4 using BBB boards, the I2C1 does not work too. This patch is the simplest solution for I2C1/I2C2 in linux-yocto-4.1.

Thanks,
Yong
-----Original Message-----
From: Tony Lindgren [mailto:tony@atomide.com] 
Sent: Tuesday, June 7, 2016 2:00 PM
To: Li, Yong B <yong.b.li@intel.com>
Cc: Robert Nelson <robertcnelson@gmail.com>; Benoit Cousson <bcousson@baylibre.com>; Rob Herring <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>; Mark Rutland <mark.rutland@arm.com>; Ian Campbell <ijc+devicetree@hellion.org.uk>; Kumar Gala <galak@codeaurora.org>; Russell King <linux@arm.linux.org.uk>; linux-omap@vger.kernel.org; devicetree <devicetree@vger.kernel.org>; linux-arm-kernel@lists.infradead.org; linux kernel <linux-kernel@vger.kernel.org>; sdliyong@gmail.com
Subject: Re: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

* Li, Yong B <yong.b.li@intel.com> [160602 22:49]:
> Hi Tony,
> 
> I can submit a V2 version about the "disabled", or just drop this patch?

Probably best to wait on this one until we know how it can be enabled without manually editing the dts file. I'm still hoping u-boot could enable it based on some environment variable..

Regards,

Tony

Re: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

[Robert Nelson]

On Tue, Jun 7, 2016 at 1:14 AM, Li, Yong B <yong.b.li@intel.com> wrote:
> Thanks Tony.
>
> I checked the DTS/overlays using linux-yocto-4.1 kernel(Ostro OS). It seems to me that the kernel/u-boot do not include the latest overlay support patch. And I also tested the latest Debian 8.4 using BBB boards, the I2C1 does not work too. This patch is the simplest solution for I2C1/I2C2 in linux-yocto-4.1.

ps, your patch is also broken, you didn't even mux the pins, so i2c1
doesn't work for you anyways. ;)

pinctrl-0 = <&i2c2_pins>; -> pinctrl-0 = <&i2c1_pins>;

Option 1:

With the latest BBB image's, we utilize "cape_universal", thus you can
enable I2C1 via:

root@beaglebone:~# config-pin -l P9.17
default gpio gpio_pu gpio_pd spi i2c pwm

root@beaglebone:~# config-pin -l P9.18
default gpio gpio_pu gpio_pd spi i2c pwm

root@beaglebone:~# config-pin P9.17 i2c

root@beaglebone:~# config-pin P9.18 i2c

Option 2, for the BB-I2C1 overlay:

add

cape_enable=bone_capemgr.enable_partno=BB-I2C1

Option 3, wait for Pantelis's solution... ;)

http://comments.gmane.org/gmane.linux.kernel/2234662

Regards,

-- 
Robert Nelson
https://rcn-ee.com/

RE: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

[Li, Yong B]

Thanks Robert!

-----Original Message-----
From: Robert Nelson [mailto:robertcnelson@gmail.com] 
Sent: Wednesday, June 8, 2016 1:15 AM
To: Li, Yong B <yong.b.li@intel.com>
Cc: Tony Lindgren <tony@atomide.com>; Benoit Cousson <bcousson@baylibre.com>; Rob Herring <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>; Mark Rutland <mark.rutland@arm.com>; Ian Campbell <ijc+devicetree@hellion.org.uk>; Kumar Gala <galak@codeaurora.org>; Russell King <linux@arm.linux.org.uk>; linux-omap@vger.kernel.org; devicetree <devicetree@vger.kernel.org>; linux-arm-kernel@lists.infradead.org; linux kernel <linux-kernel@vger.kernel.org>; sdliyong@gmail.com; Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Subject: Re: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

On Tue, Jun 7, 2016 at 1:14 AM, Li, Yong B <yong.b.li@intel.com> wrote:
> Thanks Tony.
>
> I checked the DTS/overlays using linux-yocto-4.1 kernel(Ostro OS). It seems to me that the kernel/u-boot do not include the latest overlay support patch. And I also tested the latest Debian 8.4 using BBB boards, the I2C1 does not work too. This patch is the simplest solution for I2C1/I2C2 in linux-yocto-4.1.

ps, your patch is also broken, you didn't even mux the pins, so i2c1 doesn't work for you anyways. ;)

pinctrl-0 = <&i2c2_pins>; -> pinctrl-0 = <&i2c1_pins>;

Option 1:

With the latest BBB image's, we utilize "cape_universal", thus you can enable I2C1 via:

root@beaglebone:~# config-pin -l P9.17
default gpio gpio_pu gpio_pd spi i2c pwm

root@beaglebone:~# config-pin -l P9.18
default gpio gpio_pu gpio_pd spi i2c pwm

root@beaglebone:~# config-pin P9.17 i2c

root@beaglebone:~# config-pin P9.18 i2c

Option 2, for the BB-I2C1 overlay:

add

cape_enable=bone_capemgr.enable_partno=BB-I2C1

Option 3, wait for Pantelis's solution... ;)

http://comments.gmane.org/gmane.linux.kernel/2234662

Regards,

--
Robert Nelson
https://rcn-ee.com/