From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753301AbcFGG0z (ORCPT ); Tue, 7 Jun 2016 02:26:55 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33657 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751031AbcFGG0x (ORCPT ); Tue, 7 Jun 2016 02:26:53 -0400 Date: Tue, 7 Jun 2016 08:26:50 +0200 From: Michal Hocko To: Tetsuo Handa Cc: linux-mm@kvack.org, rientjes@google.com, oleg@redhat.com, vdavydov@parallels.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 10/10] mm, oom: hide mm which is shared with kthread or global init Message-ID: <20160607062650.GA12305@dhcp22.suse.cz> References: <1464945404-30157-1-git-send-email-mhocko@kernel.org> <1464945404-30157-11-git-send-email-mhocko@kernel.org> <201606040016.BFG17115.OFMLSJFOtHQOFV@I-love.SAKURA.ne.jp> <20160606132650.GI11895@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160606132650.GI11895@dhcp22.suse.cz> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 06-06-16 15:26:50, Michal Hocko wrote: [...] > @@ -922,8 +941,17 @@ void oom_kill_process(struct oom_control *oc, struct task_struct *p, > } > rcu_read_unlock(); > > - if (can_oom_reap) > + if (can_oom_reap) { > wake_oom_reaper(victim); > + } else if (victim != current) { > + /* > + * If we want to guarantee a forward progress we cannot keep > + * the oom victim TIF_MEMDIE here. Sleep for a while and then > + * drop the flag to make sure another victim can be selected. > + */ > + schedule_timeout_killable(HZ); > + exit_oom_victim(victim); thiking about it more, with the other change in the oom_scan_process_thread we do not need to exit_oom_victim. In fact we even shouldn't because of the oom_disabled synchronization. I will respin the patch and drop the exit_oom_victim part. schedule_timeout_killable will stay... > + } > > mmdrop(mm); > put_task_struct(victim); > -- > 2.8.1 > > -- > Michal Hocko > SUSE Labs -- Michal Hocko SUSE Labs