From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754032AbcFGIFQ (ORCPT ); Tue, 7 Jun 2016 04:05:16 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:35884 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753109AbcFGIFG (ORCPT ); Tue, 7 Jun 2016 04:05:06 -0400 Date: Tue, 7 Jun 2016 09:05:38 +0100 From: Lee Jones To: Rhyland Klein Cc: Laxman Dewangan , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: max77620: Fix FPS switch statements Message-ID: <20160607080538.GG1525@dell> References: <1463075104-26924-1-git-send-email-rklein@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1463075104-26924-1-git-send-email-rklein@nvidia.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 May 2016, Rhyland Klein wrote: > When configuring FPS during probe, assuming a DT node is present for > FPS, the code can run into a problem with the switch statements in > max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely, > in the case of chip->chip_id == MAX77620, it will set > fps_[mix|max]_period but then fall through to the default switch case > and return -EINVAL. Returning this from max77620_config_fps() will > cause probe to fail. > > Signed-off-by: Rhyland Klein > --- > drivers/mfd/max77620.c | 2 ++ > 1 file changed, 2 insertions(+) Applied to -fixes with Thierry and Laxman's Acks. > diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c > index 199d261990be..f32fbb8e8129 100644 > --- a/drivers/mfd/max77620.c > +++ b/drivers/mfd/max77620.c > @@ -203,6 +203,7 @@ static int max77620_get_fps_period_reg_value(struct max77620_chip *chip, > break; > case MAX77620: > fps_min_period = MAX77620_FPS_PERIOD_MIN_US; > + break; > default: > return -EINVAL; > } > @@ -236,6 +237,7 @@ static int max77620_config_fps(struct max77620_chip *chip, > break; > case MAX77620: > fps_max_period = MAX77620_FPS_PERIOD_MAX_US; > + break; > default: > return -EINVAL; > } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog