From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754637AbcFGJHO (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Jun 2016 05:07:14 -0400
Received: from mail-wm0-f67.google.com ([74.125.82.67]:33627 "EHLO
	mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754632AbcFGJHJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Jun 2016 05:07:09 -0400
Date: Tue, 7 Jun 2016 11:07:06 +0200
From: Michal Hocko <mhocko@kernel.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Andi Kleen <andi@firstfloor.org>,
        Tim Chen <tim.c.chen@linux.intel.com>, kernel-team@fb.com
Subject: Re: [PATCH 02/10] mm: swap: unexport __pagevec_lru_add()
Message-ID: <20160607090645.GD12305@dhcp22.suse.cz>
References: <20160606194836.3624-1-hannes@cmpxchg.org>
 <20160606194836.3624-3-hannes@cmpxchg.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160606194836.3624-3-hannes@cmpxchg.org>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon 06-06-16 15:48:28, Johannes Weiner wrote:
> There is currently no modular user of this function. We used to have
> filesystems that open-coded the page cache instantiation, but luckily
> they're all streamlined, and we don't want this to come back.

allmodconfig agrees with that

> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Acked-by: Michal Hocko <mhocko@suse.com>

> ---
>  mm/swap.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/swap.c b/mm/swap.c
> index 95916142fc46..d810c3d95c97 100644
> --- a/mm/swap.c
> +++ b/mm/swap.c
> @@ -860,7 +860,6 @@ void __pagevec_lru_add(struct pagevec *pvec)
>  {
>  	pagevec_lru_move_fn(pvec, __pagevec_lru_add_fn, NULL);
>  }
> -EXPORT_SYMBOL(__pagevec_lru_add);
>  
>  /**
>   * pagevec_lookup_entries - gang pagecache lookup
> -- 
> 2.8.3

-- 
Michal Hocko
SUSE Labs