From: Masami Hiramatsu <mhiramat@kernel.org>
To: David Long <dave.long@linaro.org>
Cc: "Catalin Marinas" <catalin.marinas@arm.com>,
"Huang Shijie" <shijie.huang@arm.com>,
"James Morse" <james.morse@arm.com>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Pratyush Anand" <panand@redhat.com>,
"Sandeepa Prabhu" <sandeepa.s.prabhu@gmail.com>,
"Will Deacon" <will.deacon@arm.com>,
"William Cohen" <wcohen@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Steve Capper" <steve.capper@linaro.org>,
"Li Bin" <huawei.libin@huawei.com>,
"Adam Buchbinder" <adam.buchbinder@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Andrey Ryabinin" <ryabinin.a.a@gmail.com>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
"Christoffer Dall" <christoffer.dall@linaro.org>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Dave P Martin" <Dave.Martin@arm.com>,
"Jens Wiklander" <jens.wiklander@linaro.org>,
"Jisheng Zhang" <jszhang@marvell.com>,
"John Blackwood" <john.blackwood@ccur.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Petr Mladek" <pmladek@suse.com>,
"Robin Murphy" <robin.murphy@arm.com>,
"Suzuki K Poulose" <suzuki.poulose@arm.com>,
"Vladimir Murzin" <Vladimir.Murzin@arm.com>,
"Yang Shi" <yang.shi@linaro.org>,
"Zi Shen Lim" <zlim.lnx@gmail.com>,
"yalin wang" <yalin.wang2010@gmail.com>,
"Mark Brown" <broonie@kernel.org>
Subject: Re: [PATCH v13 06/10] arm64: Treat all entry code as non-kprobe-able
Date: Tue, 7 Jun 2016 09:34:50 +0900 [thread overview]
Message-ID: <20160607093450.05bd4105957b0beaa4190167@kernel.org> (raw)
In-Reply-To: <1464924384-15269-7-git-send-email-dave.long@linaro.org>
On Thu, 2 Jun 2016 23:26:20 -0400
David Long <dave.long@linaro.org> wrote:
> From: Pratyush Anand <panand@redhat.com>
>
> Entry symbols are not kprobe safe. So blacklist them for kprobing.
>
> Signed-off-by: Pratyush Anand <panand@redhat.com>
> Signed-off-by: David A. Long <dave.long@linaro.org>
Looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> arch/arm64/kernel/entry.S | 3 +++
> arch/arm64/kernel/kprobes.c | 26 ++++++++++++++++++++++++++
> arch/arm64/kernel/vmlinux.lds.S | 1 +
> 3 files changed, 30 insertions(+)
>
> diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
> index 12e8d2b..7d99bed 100644
> --- a/arch/arm64/kernel/entry.S
> +++ b/arch/arm64/kernel/entry.S
> @@ -243,6 +243,7 @@ tsk .req x28 // current thread_info
> * Exception vectors.
> */
>
> + .pushsection ".entry.text", "ax"
> .align 11
> ENTRY(vectors)
> ventry el1_sync_invalid // Synchronous EL1t
> @@ -781,3 +782,5 @@ ENTRY(sys_rt_sigreturn_wrapper)
> mov x0, sp
> b sys_rt_sigreturn
> ENDPROC(sys_rt_sigreturn_wrapper)
> +
> + .popsection
> diff --git a/arch/arm64/kernel/kprobes.c b/arch/arm64/kernel/kprobes.c
> index 49b06cf..ba43623 100644
> --- a/arch/arm64/kernel/kprobes.c
> +++ b/arch/arm64/kernel/kprobes.c
> @@ -30,6 +30,7 @@
> #include <asm/insn.h>
> #include <asm/uaccess.h>
> #include <asm/irq.h>
> +#include <asm-generic/sections.h>
>
> #include "kprobes-arm64.h"
>
> @@ -520,6 +521,31 @@ int __kprobes longjmp_break_handler(struct kprobe *p, struct pt_regs *regs)
> return 1;
> }
>
> +bool arch_within_kprobe_blacklist(unsigned long addr)
> +{
> + extern char __idmap_text_start[], __idmap_text_end[];
> + extern char __hyp_idmap_text_start[], __hyp_idmap_text_end[];
> +
> + if ((addr >= (unsigned long)__kprobes_text_start &&
> + addr < (unsigned long)__kprobes_text_end) ||
> + (addr >= (unsigned long)__entry_text_start &&
> + addr < (unsigned long)__entry_text_end) ||
> + (addr >= (unsigned long)__idmap_text_start &&
> + addr < (unsigned long)__idmap_text_end) ||
> + !!search_exception_tables(addr))
> + return true;
> +
> + if (!is_kernel_in_hyp_mode()) {
> + if ((addr >= (unsigned long)__hyp_text_start &&
> + addr < (unsigned long)__hyp_text_end) ||
> + (addr >= (unsigned long)__hyp_idmap_text_start &&
> + addr < (unsigned long)__hyp_idmap_text_end))
> + return true;
> + }
> +
> + return false;
> +}
> +
> int __init arch_init_kprobes(void)
> {
> return 0;
> diff --git a/arch/arm64/kernel/vmlinux.lds.S b/arch/arm64/kernel/vmlinux.lds.S
> index 075ce32..9f59394 100644
> --- a/arch/arm64/kernel/vmlinux.lds.S
> +++ b/arch/arm64/kernel/vmlinux.lds.S
> @@ -118,6 +118,7 @@ SECTIONS
> __exception_text_end = .;
> IRQENTRY_TEXT
> SOFTIRQENTRY_TEXT
> + ENTRY_TEXT
> TEXT_TEXT
> SCHED_TEXT
> LOCK_TEXT
> --
> 2.5.0
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2016-06-07 0:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 3:26 [PATCH v13 00/10] arm64: Add kernel probes (kprobes) support David Long
2016-06-03 3:26 ` [PATCH v13 01/10] arm64: Add HAVE_REGS_AND_STACK_ACCESS_API feature David Long
2016-06-03 11:36 ` Masami Hiramatsu
2016-06-20 2:43 ` Li Bin
2016-06-23 13:48 ` David Long
2016-06-03 3:26 ` [PATCH v13 02/10] arm64: Add more test functions to insn.c David Long
2016-06-08 1:14 ` Masami Hiramatsu
2016-06-10 14:54 ` David Long
2016-06-03 3:26 ` [PATCH v13 03/10] arm64: add conditional instruction simulation support David Long
2016-06-04 3:53 ` Masami Hiramatsu
2016-06-13 4:19 ` David Long
2016-06-03 3:26 ` [PATCH v13 04/10] arm64: Blacklist non-kprobe-able symbol David Long
2016-06-04 3:40 ` Masami Hiramatsu
2016-06-07 3:52 ` David Long
2016-06-10 19:16 ` David Long
2016-06-03 3:26 ` [PATCH v13 05/10] arm64: Kprobes with single stepping support David Long
2016-06-08 1:07 ` Masami Hiramatsu
2016-06-13 4:10 ` David Long
2016-06-13 6:50 ` Masami Hiramatsu
2016-06-13 15:22 ` David Long
2016-06-14 0:45 ` Masami Hiramatsu
2016-06-22 18:28 ` David Long
2016-06-14 1:42 ` Masami Hiramatsu
2016-06-03 3:26 ` [PATCH v13 06/10] arm64: Treat all entry code as non-kprobe-able David Long
2016-06-07 0:34 ` Masami Hiramatsu [this message]
2016-06-03 3:26 ` [PATCH v13 07/10] arm64: kprobes instruction simulation support David Long
2016-06-03 3:26 ` [PATCH v13 08/10] arm64: Add trampoline code for kretprobes David Long
2016-06-07 10:38 ` Masami Hiramatsu
2016-06-13 4:23 ` David Long
2016-06-03 3:26 ` [PATCH v13 09/10] arm64: Add kernel return probes support (kretprobes) David Long
2016-06-07 10:28 ` Masami Hiramatsu
2016-06-22 18:16 ` David Long
2016-06-03 3:26 ` [PATCH v13 10/10] kprobes: Add arm64 case in kprobe example module David Long
2016-06-07 10:12 ` Masami Hiramatsu
2016-06-08 5:49 ` Huang Shijie
2016-06-27 2:54 ` David Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607093450.05bd4105957b0beaa4190167@kernel.org \
--to=mhiramat@kernel.org \
--cc=Dave.Martin@arm.com \
--cc=Vladimir.Murzin@arm.com \
--cc=adam.buchbinder@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alex.bennee@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dave.long@linaro.org \
--cc=huawei.libin@huawei.com \
--cc=james.morse@arm.com \
--cc=jens.wiklander@linaro.org \
--cc=john.blackwood@ccur.com \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=panand@redhat.com \
--cc=pmladek@suse.com \
--cc=robin.murphy@arm.com \
--cc=ryabinin.a.a@gmail.com \
--cc=sandeepa.s.prabhu@gmail.com \
--cc=shijie.huang@arm.com \
--cc=steve.capper@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=wcohen@redhat.com \
--cc=will.deacon@arm.com \
--cc=yalin.wang2010@gmail.com \
--cc=yang.shi@linaro.org \
--cc=zlim.lnx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).