From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755140AbcFGKfb (ORCPT ); Tue, 7 Jun 2016 06:35:31 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:34646 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753967AbcFGKfa (ORCPT ); Tue, 7 Jun 2016 06:35:30 -0400 Date: Tue, 7 Jun 2016 18:35:15 +0800 From: Herbert Xu To: Megha Dey Cc: tim.c.chen@linux.intel.com, davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, fenghua.yu@intel.com, Megha Dey Subject: Re: [PATCH V2 2/2] crypto : async implementation for sha1-mb Message-ID: <20160607103515.GB325@gondor.apana.org.au> References: <1464922430-26976-1-git-send-email-megha.dey@intel.com> <1464922430-26976-3-git-send-email-megha.dey@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464922430-26976-3-git-send-email-megha.dey@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 02, 2016 at 07:53:50PM -0700, Megha Dey wrote: > > + struct ahash_alg *shash = crypto_ahash_alg(tfm); > > /* alignment is to be done by multi-buffer crypto algorithm if needed */ > > - return shash->finup(desc, NULL, 0, req->result); > + return shash->finup(desc); You're still poking in the guts of the API. Now that it's a real ahash you don't need to do that. Just do crypto_ahash_finup. That way you don't need to export crypto_ahsh_alg either. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt