From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755200AbcFGKru (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Jun 2016 06:47:50 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47250 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755167AbcFGKrr (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Jun 2016 06:47:47 -0400
Date: Tue, 7 Jun 2016 11:47:11 +0100
From: Mark Brown <broonie@kernel.org>
To: Xing Zheng <zhengxing@rock-chips.com>
Cc: Rob Herring <robh@kernel.org>, linux-rockchip@lists.infradead.org,
        dianders@chromium.org, heiko@sntech.de,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Message-ID: <20160607104711.GR7510@sirena.org.uk>
References: <1464267742-15312-1-git-send-email-zhengxing@rock-chips.com>
 <20160601144542.GA3835@rob-hp-laptop>
 <5751912C.6080904@rock-chips.com>
 <20160606235026.GP7510@sirena.org.uk>
 <5756363F.40208@rock-chips.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="VdnGiXwuH6t1Tqzo"
Content-Disposition: inline
In-Reply-To: <5756363F.40208@rock-chips.com>
X-Cookie: We've upped our standards, so up yours!
User-Agent: Mutt/1.6.0 (2016-04-01)
X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH v3] ASoC: rockchip: Add machine driver for
 MAX98357A/RT5514/DA7219
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--VdnGiXwuH6t1Tqzo
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 07, 2016 at 10:49:35AM +0800, Xing Zheng wrote:
> On 2016=E5=B9=B406=E6=9C=8807=E6=97=A5 07:50, Mark Brown wrote:

> > It should probably be three compatibles, one per CODEC, if the driver
> > needs to handle each separately.

> Do you mean like this:
> --------
> sound {
> compatible =3D "rockchip,rk3399-max98357a-rt5514-da7219";
>=20
> dailink-0 {
> compatible =3D "rockchip,rk3399-max98357a";
> rockchip,cpu =3D <&i2s0>;
> rockchip,codec =3D <&max98357a>;
> };
>=20
> dailink-1 {
> compatible =3D "rockchip,rk3399-rt5514";
> rockchip,cpu =3D <&i2s0>;
> rockchip,codec =3D <&headsetcodec>;
> };
>=20
> dailink-2 {
> compatible =3D "rockchip,rk3399-da7219";
> rockchip,cpu =3D <&i2s0>;
> rockchip,codec =3D <&codec>;
> };
> };
> --------
> Above, the machine drvier will handle them. Please correct me if I
> misunderstand.

No, that'd be one card with all three CODECs on the same board which I'm
guessing isn't the intention?

--VdnGiXwuH6t1Tqzo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJXVqYtAAoJECTWi3JdVIfQEnUH/jYkld4xArmLDUmrUa4dE8po
flWubc26O/KP8rlBo9SRxNpzwZnL7Ptb7ROX44tbD3pR5L/uCx8zadyYOtk4C8mt
jKvj/1jBSqbiK4ZAP2wYvqjybbWLM8gvfrbcDUT+b87LkfHTUvHvGH9Mt4IY3Azd
6LR4755eK0niT/oIcZ8t+KQnij7bpgX40tvd3brmRfFOW9jvpzZUrdrKYgZ1z0Oy
IVuN23Z1Ml4lS02ROsVZJ9jHUG7Vv8YipErWqFnxLGHnumn0XrIQf6gP3hapQB1g
yOQ2uU8uM5iGZLJEpTGAE/UqWtXP7FRdtHNO2EEWT1LJSb5RTwMRVocFE/wGONs=
=7Caj
-----END PGP SIGNATURE-----

--VdnGiXwuH6t1Tqzo--