From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755450AbcFGMHi (ORCPT ); Tue, 7 Jun 2016 08:07:38 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47456 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754551AbcFGMHf (ORCPT ); Tue, 7 Jun 2016 08:07:35 -0400 Date: Tue, 7 Jun 2016 13:06:47 +0100 From: Mark Brown To: Xing Zheng Cc: Rob Herring , linux-rockchip@lists.infradead.org, dianders@chromium.org, heiko@sntech.de, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Message-ID: <20160607120647.GV7510@sirena.org.uk> References: <1464267742-15312-1-git-send-email-zhengxing@rock-chips.com> <20160601144542.GA3835@rob-hp-laptop> <5751912C.6080904@rock-chips.com> <20160606235026.GP7510@sirena.org.uk> <5756363F.40208@rock-chips.com> <20160607104711.GR7510@sirena.org.uk> <5756B22F.9000105@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SidV/bKy1CyabPX8" Content-Disposition: inline In-Reply-To: <5756B22F.9000105@rock-chips.com> X-Cookie: We've upped our standards, so up yours! User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v3] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --SidV/bKy1CyabPX8 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 07, 2016 at 07:38:23PM +0800, Xing Zheng wrote: > On 2016=E5=B9=B406=E6=9C=8807=E6=97=A5 18:47, Mark Brown wrote: > > No, that'd be one card with all three CODECs on the same board which I'm > > guessing isn't the intention? > Yes, because on our board, the audio connection by hardware really is suc= h: > |-- max98357a > i2s0 <=3D=3D> |-- rt5514 > | -- da7219 > We do need to support max98357a / rt5514 / da7219 via i2s0 on the same bo= ard > for RK3399. > I remember that it will be failed if we register card with i2s0 more time= s. > Therefore, I chose this mothod that create 3 dai-links on one machine > driver. OK, then the original name probably makes some sense though really that's such an unusual design that just naming it after the specific board might be better, it's not likely to see any reuse I'd guess. --SidV/bKy1CyabPX8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXVrjWAAoJECTWi3JdVIfQmlwH/321+pXBIgMXijx++JtXsHvZ msdn9EAlBD+fCxF3ggxJkNP2xv4O8C/3njIzV3dDYqp9MaJfkXWn14DSip3uELkO NRiTpM1UshR0wLirCmgiSjmxtyTVC9yLVtkRVYVYJMwMlauPpoNh52ssq5LvM+de wvv3CvC9JaRX1OmiM/jTAkBjaJVZL8O9ttfbbgJKjX6Wq1gaPKM9QyFEPFwasjC3 ci5RNIfi32Ar6wWmMCGdzLiNAvj5jsslw3JXV6Jpb3bdU7yzAWCjXDEan4iQKTsB LyUEkjM3oAQOkF2Zulv+cOgQIAm9MCNkUksMuBxT2jg4cb/dlvVK6Qe3Z7g08U4= =LMu1 -----END PGP SIGNATURE----- --SidV/bKy1CyabPX8--