From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161141AbcFGOM5 (ORCPT ); Tue, 7 Jun 2016 10:12:57 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:58368 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932914AbcFGOM4 (ORCPT ); Tue, 7 Jun 2016 10:12:56 -0400 Date: Tue, 7 Jun 2016 10:12:48 -0400 From: Johannes Weiner To: Rik van Riel Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Mel Gorman , Andrea Arcangeli , Andi Kleen , Michal Hocko , Tim Chen , kernel-team@fb.com Subject: Re: [PATCH 07/10] mm: base LRU balancing on an explicit cost model Message-ID: <20160607141248.GD9978@cmpxchg.org> References: <20160606194836.3624-1-hannes@cmpxchg.org> <20160606194836.3624-8-hannes@cmpxchg.org> <1465266883.16365.154.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465266883.16365.154.camel@redhat.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2016 at 10:34:43PM -0400, Rik van Riel wrote: > On Mon, 2016-06-06 at 15:48 -0400, Johannes Weiner wrote: > > Currently, scan pressure between the anon and file LRU lists is > > balanced based on a mixture of reclaim efficiency and a somewhat > > vague > > notion of "value" of having certain pages in memory over others. That > > concept of value is problematic, because it has caused us to count > > any > > event that remotely makes one LRU list more or less preferrable for > > reclaim, even when these events are not directly comparable to each > > other and impose very different costs on the system - such as a > > referenced file page that we still deactivate and a referenced > > anonymous page that we actually rotate back to the head of the list. > > > > Well, patches 7-10 answered my question on patch 6 :) > > I like this design. Great! Thanks for reviewing.