From: Keith Busch <keith.busch@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Ming Lin <ming.l@ssi.samsung.com>
Subject: Re: [PATCH 1/8] blk-mq: add blk_mq_alloc_request_hctx
Date: Tue, 7 Jun 2016 10:57:36 -0400 [thread overview]
Message-ID: <20160607145736.GB28414@localhost.localdomain> (raw)
In-Reply-To: <1465248119-17875-2-git-send-email-hch@lst.de>
On Mon, Jun 06, 2016 at 11:21:52PM +0200, Christoph Hellwig wrote:
> +struct request *blk_mq_alloc_request_hctx(struct request_queue *q, int rw,
> + unsigned int flags, unsigned int hctx_idx)
> +{
> + struct blk_mq_hw_ctx *hctx;
> + struct blk_mq_ctx *ctx;
> + struct request *rq;
> + struct blk_mq_alloc_data alloc_data;
> + int ret;
> +
> + ret = blk_queue_enter(q, flags & BLK_MQ_REQ_NOWAIT);
> + if (ret)
> + return ERR_PTR(ret);
> +
> + hctx = q->queue_hw_ctx[hctx_idx];
We probably want to check 'if (hctx_idx < q->nr_hw_queues)' before
getting the hctx. Even if hctx_idx was origially valid, it's possible
(though unlikely) blk_queue_enter waits on reallocating h/w contexts,
which can make hctx_idx invalid.
next prev parent reply other threads:[~2016-06-07 14:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 21:21 generic NVMe over Fabrics library support Christoph Hellwig
2016-06-06 21:21 ` [PATCH 1/8] blk-mq: add blk_mq_alloc_request_hctx Christoph Hellwig
2016-06-07 14:57 ` Keith Busch [this message]
2016-06-07 15:27 ` Ming Lin
2016-06-07 23:21 ` Ming Lin
2016-06-08 4:49 ` Jens Axboe
2016-06-08 5:20 ` Ming Lin
2016-06-08 11:56 ` Christoph Hellwig
2016-06-08 11:54 ` Christoph Hellwig
2016-06-06 21:21 ` [PATCH 2/8] nvme: allow transitioning from NEW to LIVE state Christoph Hellwig
2016-06-06 21:21 ` [PATCH 3/8] nvme: Modify and export sync command submission for fabrics Christoph Hellwig
2016-06-06 21:21 ` [PATCH 4/8] nvme: add fabrics sysfs attributes Christoph Hellwig
2016-06-07 8:52 ` Johannes Thumshirn
2016-06-07 10:51 ` Christoph Hellwig
2016-06-07 15:21 ` Christoph Hellwig
2016-06-06 21:21 ` [PATCH 5/8] nvme.h: add NVMe over Fabrics definitions Christoph Hellwig
2016-06-06 21:21 ` [PATCH 6/8] nvme-fabrics: add a generic NVMe over Fabrics library Christoph Hellwig
2016-06-06 21:21 ` [PATCH 7/8] nvme.h: Add keep-alive opcode and identify controller attribute Christoph Hellwig
2016-06-06 21:21 ` [PATCH 8/8] nvme: add keep-alive support Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607145736.GB28414@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.l@ssi.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).