linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Hekuang <hekuang@huawei.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
	peterz@infradead.org, mingo@redhat.com,
	alexander.shishkin@linux.intel.com, wangnan0@huawei.com,
	jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com,
	namhyung@kernel.org, adrian.hunter@intel.com,
	sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com,
	tumanova@linux.vnet.ibm.com, kan.liang@intel.com,
	penberg@kernel.org, dsahern@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 00/14] Add support for remote unwind
Date: Tue, 7 Jun 2016 12:14:28 -0300	[thread overview]
Message-ID: <20160607151428.GC11589@kernel.org> (raw)
In-Reply-To: <20160607151215.GB11589@kernel.org>

Em Tue, Jun 07, 2016 at 12:12:15PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Sat, Jun 04, 2016 at 01:39:04PM +0800, Hekuang escreveu:
> > 在 2016/6/4 5:09, Arnaldo Carvalho de Melo 写道:
> > > Em Fri, Jun 03, 2016 at 06:06:02PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > > Anyway, please try your patchkit with 'perf top' and 'perf trace', as
> > > > both don't use perf.data files, i.e. they work 'live', so probably
> > > > things that you touch in normalize_arch() are not initialized and need
> > > > to be setup.
> > > Ah, no need to resend the whole patchkit, just find out what is the bug
> > > and send me a patch and I'll insert it at the right point to avoid
> > > introducing a bisect breaking point.
> 
> > > Your patchkit is in my perf/unwind branch at my tree, I already added
> > > Jiri's Acked-by in all the patches.
> 
> > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git
> 
> > I send the updated one after PATCH 10/14,  env->arch is null in live mode,
> > comments are added and "perf top/trace" works now.
> 
> Ok, now it fails 'perf test unwind' and I bisected it to:

Further info:

[root@jouet ~]# perf test -v unwind
48: Test dwarf unwind                                        :
--- start ---
test child forked, pid 25078
got wrong number of stack entries 0 != 8
test child finished with -1
---- end ----
Test dwarf unwind: FAILED!
[root@jouet ~]#
 
> [acme@jouet linux]$ git bisect good
> e2b6ce1ca32cedeb2cef08f49aa812f0eadcc3c5 is the first bad commit
> commit e2b6ce1ca32cedeb2cef08f49aa812f0eadcc3c5
> Author: He Kuang <hekuang@huawei.com>
> Date:   Fri Jun 3 03:33:19 2016 +0000
> 
>     perf unwind: Check the target platform before assigning unwind methods
>     
>     Currently, 'perf script' uses host unwind methods to parse perf.data
>     callchain info without taking the target architecture into account, i.e.
>     assuming the perf.data file was generated on the same machine where the
>     analysis is being performed. So we get wrong result without any warnings
>     when unwinding callchains of x86(32-bit) on x86(64-bit) machine.
>     
>     This patch adds an extra step that checks the target platform before
>     assigning unwind methods. In later patches in this series, we can use
>     this info to assign the right unwind methods for supported platforms.
> 

  reply	other threads:[~2016-06-07 15:14 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03  3:33 He Kuang
2016-06-03  3:33 ` [PATCH v9 01/14] perf tools: Use LIBUNWIND_DIR for remote libunwind feature check He Kuang
2016-06-08  8:45   ` [tip:perf/core] perf unwind: " tip-bot for He Kuang
2016-06-03  3:33 ` [PATCH v9 02/14] perf tools: Decouple thread->address_space on libunwind He Kuang
2016-06-08  8:46   ` [tip:perf/core] perf unwind: " tip-bot for He Kuang
2016-06-03  3:33 ` [PATCH v9 03/14] perf tools: Introducing struct unwind_libunwind_ops for local unwind He Kuang
2016-06-08  8:46   ` [tip:perf/core] perf unwind: Introduce 'struct unwind_libunwind_ops' " tip-bot for He Kuang
2016-06-03  3:33 ` [PATCH v9 04/14] perf tools: Move unwind__prepare_access from thread_new into thread__insert_map He Kuang
2016-06-08  8:47   ` [tip:perf/core] perf unwind: " tip-bot for He Kuang
2016-06-03  3:33 ` [PATCH v9 05/14] perf tools: Don't mix LIBUNWIND_LIBS into LIBUNWIND_LDFLAGS He Kuang
2016-06-08  8:47   ` [tip:perf/core] perf unwind: " tip-bot for He Kuang
2016-06-03  3:33 ` [PATCH v9 06/14] perf tools: Separate local/remote libunwind config He Kuang
2016-06-08  8:47   ` [tip:perf/core] perf unwind: " tip-bot for He Kuang
2016-06-03  3:33 ` [PATCH v9 07/14] perf tools: Rename unwind-libunwind.c to unwind-libunwind-local.c He Kuang
2016-06-08  8:48   ` [tip:perf/core] perf unwind: " tip-bot for He Kuang
2016-06-03  3:33 ` [PATCH v9 08/14] perf tools: Extract common API out of unwind-libunwind-local.c He Kuang
2016-06-08  8:48   ` [tip:perf/core] " tip-bot for He Kuang
2016-06-03  3:33 ` [PATCH v9 09/14] perf tools: Export normalize_arch() function He Kuang
2016-06-08  8:49   ` [tip:perf/core] " tip-bot for He Kuang
2016-06-03  3:33 ` [PATCH v9 10/14] perf tools: Check the target platform before assigning unwind methods He Kuang
2016-06-04  5:36   ` [PATCH v9 10/14 UPDATE] " He Kuang
2016-06-07 18:06     ` Arnaldo Carvalho de Melo
2016-06-08  8:49   ` [tip:perf/core] perf unwind: " tip-bot for He Kuang
2016-06-03  3:33 ` [PATCH v9 11/14] perf tools: Change fixed name of libunwind__arch_reg_id to macro He Kuang
2016-06-08  8:50   ` [tip:perf/core] perf unwind: " tip-bot for He Kuang
2016-06-03  3:33 ` [PATCH v9 12/14] perf tools: Introduce flag to separate local/remote unwind compilation He Kuang
2016-06-08  8:50   ` [tip:perf/core] perf unwind: " tip-bot for He Kuang
2016-06-03  3:33 ` [PATCH v9 13/14] perf callchain: Support x86 target platform He Kuang
2016-06-08  8:51   ` [tip:perf/core] " tip-bot for He Kuang
2016-06-03  3:33 ` [PATCH v9 14/14] perf callchain: Support aarch64 cross-platform He Kuang
2016-06-08  8:51   ` [tip:perf/core] " tip-bot for He Kuang
2016-06-03  7:06 ` [PATCH v9 00/14] Add support for remote unwind Jiri Olsa
2016-06-03 19:42   ` Arnaldo Carvalho de Melo
2016-06-03 21:06     ` Arnaldo Carvalho de Melo
2016-06-03 21:09       ` Arnaldo Carvalho de Melo
2016-06-04  5:39         ` Hekuang
2016-06-07 15:12           ` Arnaldo Carvalho de Melo
2016-06-07 15:14             ` Arnaldo Carvalho de Melo [this message]
2016-06-07 19:44   ` Arnaldo Carvalho de Melo
2016-06-08  7:33     ` Hekuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160607151428.GC11589@kernel.org \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=hekuang@huawei.com \
    --cc=jolsa@redhat.com \
    --cc=jpoimboe@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=penberg@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=tumanova@linux.vnet.ibm.com \
    --cc=wangnan0@huawei.com \
    --subject='Re: [PATCH v9 00/14] Add support for remote unwind' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).