From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161615AbcFGPOg (ORCPT ); Tue, 7 Jun 2016 11:14:36 -0400 Received: from mail.kernel.org ([198.145.29.136]:49269 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161555AbcFGPOd (ORCPT ); Tue, 7 Jun 2016 11:14:33 -0400 Date: Tue, 7 Jun 2016 12:14:28 -0300 From: Arnaldo Carvalho de Melo To: Hekuang Cc: Jiri Olsa , peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 00/14] Add support for remote unwind Message-ID: <20160607151428.GC11589@kernel.org> References: <1464924803-22214-1-git-send-email-hekuang@huawei.com> <20160603070629.GB23006@krava> <20160603194205.GB27920@kernel.org> <20160603210602.GA3095@kernel.org> <20160603210927.GB3095@kernel.org> <57526978.6070905@huawei.com> <20160607151215.GB11589@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160607151215.GB11589@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Jun 07, 2016 at 12:12:15PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Sat, Jun 04, 2016 at 01:39:04PM +0800, Hekuang escreveu: > > 在 2016/6/4 5:09, Arnaldo Carvalho de Melo 写道: > > > Em Fri, Jun 03, 2016 at 06:06:02PM -0300, Arnaldo Carvalho de Melo escreveu: > > > > Anyway, please try your patchkit with 'perf top' and 'perf trace', as > > > > both don't use perf.data files, i.e. they work 'live', so probably > > > > things that you touch in normalize_arch() are not initialized and need > > > > to be setup. > > > Ah, no need to resend the whole patchkit, just find out what is the bug > > > and send me a patch and I'll insert it at the right point to avoid > > > introducing a bisect breaking point. > > > > Your patchkit is in my perf/unwind branch at my tree, I already added > > > Jiri's Acked-by in all the patches. > > > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > > > I send the updated one after PATCH 10/14, env->arch is null in live mode, > > comments are added and "perf top/trace" works now. > > Ok, now it fails 'perf test unwind' and I bisected it to: Further info: [root@jouet ~]# perf test -v unwind 48: Test dwarf unwind : --- start --- test child forked, pid 25078 got wrong number of stack entries 0 != 8 test child finished with -1 ---- end ---- Test dwarf unwind: FAILED! [root@jouet ~]# > [acme@jouet linux]$ git bisect good > e2b6ce1ca32cedeb2cef08f49aa812f0eadcc3c5 is the first bad commit > commit e2b6ce1ca32cedeb2cef08f49aa812f0eadcc3c5 > Author: He Kuang > Date: Fri Jun 3 03:33:19 2016 +0000 > > perf unwind: Check the target platform before assigning unwind methods > > Currently, 'perf script' uses host unwind methods to parse perf.data > callchain info without taking the target architecture into account, i.e. > assuming the perf.data file was generated on the same machine where the > analysis is being performed. So we get wrong result without any warnings > when unwinding callchains of x86(32-bit) on x86(64-bit) machine. > > This patch adds an extra step that checks the target platform before > assigning unwind methods. In later patches in this series, we can use > this info to assign the right unwind methods for supported platforms. >