From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161832AbcFGQdv (ORCPT ); Tue, 7 Jun 2016 12:33:51 -0400 Received: from down.free-electrons.com ([37.187.137.238]:44911 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1161226AbcFGQdt (ORCPT ); Tue, 7 Jun 2016 12:33:49 -0400 Date: Tue, 7 Jun 2016 18:33:36 +0200 From: Alexandre Belloni To: Stephen Boyd Cc: Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jisheng Zhang , Sebastian Hesselbarth Subject: Re: [PATCH 07/34] clk: berlin: Migrate to clk_hw based registration and OF APIs Message-ID: <20160607163336.GM3363@piout.net> References: <20160601231533.9354-1-stephen.boyd@linaro.org> <20160601231533.9354-8-stephen.boyd@linaro.org> <20160605174157.GP4594@piout.net> <146528884761.28742.8093002152658120585@sboyd-linaro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <146528884761.28742.8093002152658120585@sboyd-linaro> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/2016 at 01:40:47 -0700, Stephen Boyd wrote : > Quoting Alexandre Belloni (2016-06-05 10:41:57) > > Hi, > > > > The main drawback of those patches is that they break the alignment > > (checkpatch.pl --strict complains). > > Didn't checkpatch --strict already warn on these files though? I'm not > sure I've done anything to break the alignment style here. > As you change the function return value, the function arguments are no longer aligned with the opening parenthesis. I would agree that keeping the alignment will make the change quit bigger though. > > > > On 01/06/2016 at 16:15:06 -0700, Stephen Boyd wrote : > > > diff --git a/drivers/clk/berlin/berlin2-avpll.h b/drivers/clk/berlin/berlin2-avpll.h > > > index a37f5068d299..17e311153b42 100644 > > > --- a/drivers/clk/berlin/berlin2-avpll.h > > > +++ b/drivers/clk/berlin/berlin2-avpll.h > > > @@ -19,17 +19,13 @@ > > > #ifndef __BERLIN2_AVPLL_H > > > #define __BERLIN2_AVPLL_H > > > > > > -struct clk; > > > - > > > #define BERLIN2_AVPLL_BIT_QUIRK BIT(0) > > > #define BERLIN2_AVPLL_SCRAMBLE_QUIRK BIT(1) > > > > > > -struct clk * __init > > > -berlin2_avpll_vco_register(void __iomem *base, const char *name, > > > +int berlin2_avpll_vco_register(void __iomem *base, const char *name, > > > > This is missing __init. > > Ah I also removed __init in the header file here because it doesn't do > anything. I guess I should mention that in the commit text. Indeed, you are right. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com