From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422707AbcFGQm2 (ORCPT ); Tue, 7 Jun 2016 12:42:28 -0400 Received: from guitar.tcltek.co.il ([192.115.133.116]:43423 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161751AbcFGQm1 (ORCPT ); Tue, 7 Jun 2016 12:42:27 -0400 Date: Tue, 7 Jun 2016 19:42:21 +0300 From: Baruch Siach To: Ben Dooks Cc: linux-kernel@lists.codethink.co.uk, Daniel Lezcano , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clocksource/drivers/digicolor: fix warning of non-static function Message-ID: <20160607164221.GI2425@tarshish> References: <1465308710-18297-1-git-send-email-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465308710-18297-1-git-send-email-ben.dooks@codethink.co.uk> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ben, On Tue, Jun 07, 2016 at 03:11:50PM +0100, Ben Dooks wrote: > Change the dc_timer function to be static as it is not used outside > this driver. This fixes the following warning: > > drivers/clocksource/timer-digicolor.c:66:24: warning: symbol 'dc_timer' was not declared. Should it be static? > > Signed-off-by: Ben Dooks Acked-by: Baruch Siach Thanks, baruch > --- > Cc: Daniel Lezcano > Cc: Thomas Gleixner > Cc: Baruch Siach > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/clocksource/timer-digicolor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clocksource/timer-digicolor.c b/drivers/clocksource/timer-digicolor.c > index a536eeb..96bb222 100644 > --- a/drivers/clocksource/timer-digicolor.c > +++ b/drivers/clocksource/timer-digicolor.c > @@ -63,7 +63,7 @@ struct digicolor_timer { > int timer_id; /* one of TIMER_* */ > }; > > -struct digicolor_timer *dc_timer(struct clock_event_device *ce) > +static struct digicolor_timer *dc_timer(struct clock_event_device *ce) > { > return container_of(ce, struct digicolor_timer, ce); > } -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -