From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422728AbcFGQsF (ORCPT ); Tue, 7 Jun 2016 12:48:05 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:34778 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161601AbcFGQsA (ORCPT ); Tue, 7 Jun 2016 12:48:00 -0400 From: Stephen Boyd To: linux-kernel@vger.kernel.org Cc: Vikram Mulukutla , linux-arm-kernel@lists.infradead.org, Mimi Zohar , Andrew Morton , Mark Brown , Ming Lei Subject: [RESEND/PATCHv4 v4 2/3] firmware: Provide infrastructure to make fw caching optional Date: Tue, 7 Jun 2016 09:47:40 -0700 Message-Id: <20160607164741.31849-3-stephen.boyd@linaro.org> X-Mailer: git-send-email 2.9.0-rc1 In-Reply-To: <20160607164741.31849-1-stephen.boyd@linaro.org> References: <20160607164741.31849-1-stephen.boyd@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vikram Mulukutla Some low memory systems with complex peripherals cannot afford to have the relatively large firmware images taking up valuable memory during suspend and resume. Change the internal implementation of firmware_class to disallow caching based on a configurable option. In the near future, variants of request_firmware will take advantage of this feature. Signed-off-by: Vikram Mulukutla [stephen.boyd@linaro.org: Drop firmware_desc design and use flags] Signed-off-by: Stephen Boyd --- drivers/base/firmware_class.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index 01d55723d82c..45ed20cefa10 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -112,6 +112,7 @@ static inline long firmware_loading_timeout(void) #define FW_OPT_FALLBACK 0 #endif #define FW_OPT_NO_WARN (1U << 3) +#define FW_OPT_NOCACHE (1U << 4) struct firmware_cache { /* firmware_buf instance will be added into the below list */ @@ -1065,14 +1066,16 @@ static int assign_firmware_buf(struct firmware *fw, struct device *device, * should be fixed in devres or driver core. */ /* don't cache firmware handled without uevent */ - if (device && (opt_flags & FW_OPT_UEVENT)) + if (device && (opt_flags & FW_OPT_UEVENT) && + !(opt_flags & FW_OPT_NOCACHE)) fw_add_devm_name(device, buf->fw_id); /* * After caching firmware image is started, let it piggyback * on request firmware. */ - if (buf->fwc->state == FW_LOADER_START_CACHE) { + if (!(opt_flags & FW_OPT_NOCACHE) && + buf->fwc->state == FW_LOADER_START_CACHE) { if (fw_cache_piggyback_on_request(buf->fw_id)) kref_get(&buf->ref); } -- 2.9.0-rc1