From: Baruch Siach <baruch@tkos.co.il>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kishon@ti.com,
lee.jones@linaro.org, patches@linaro.org
Subject: Re: [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: Remove site specific OOM error message
Date: Tue, 7 Jun 2016 21:35:05 +0300 [thread overview]
Message-ID: <20160607183505.GJ2425@tarshish> (raw)
In-Reply-To: <1465321810-22470-1-git-send-email-peter.griffin@linaro.org>
Hi Peter,
On Tue, Jun 07, 2016 at 06:50:09PM +0100, Peter Griffin wrote:
> kzalloc will issue its own error message including a dump_stack()
> so remote the site specific message.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> drivers/phy/phy-qcom-ufs-qmp-14nm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/phy/phy-qcom-ufs-qmp-14nm.c b/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> index 56631e7..958e9cc 100644
> --- a/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> +++ b/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> @@ -139,11 +139,9 @@ static int ufs_qcom_phy_qmp_14nm_probe(struct platform_device *pdev)
> int err = 0;
>
> phy = devm_kzalloc(dev, sizeof(*phy), GFP_KERNEL);
> - if (!phy) {
> - dev_err(dev, "%s: failed to allocate phy\n", __func__);
> + if (!phy)
> err = -ENOMEM;
> goto out;
> - }
Are you sure? The 'goto' is now unconditional.
>
> generic_phy = ufs_qcom_phy_generic_probe(pdev, &phy->common_cfg,
> &ufs_qcom_phy_qmp_14nm_phy_ops, &phy_14nm_ops);
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2016-06-07 18:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 17:50 [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: Remove site specific OOM error message Peter Griffin
2016-06-07 17:50 ` [PATCH 2/2] phy: phy-qcom-ufs-qmp-20nm: " Peter Griffin
2016-06-07 18:35 ` Baruch Siach [this message]
2016-06-08 8:46 ` [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: " Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607183505.GJ2425@tarshish \
--to=baruch@tkos.co.il \
--cc=kishon@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=peter.griffin@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).