From: Darren Hart <dvhart@infradead.org>
To: Lyude Paul <cpaul@redhat.com>
Cc: "ibm-acpi-devel@lists.sourceforge.net"
<ibm-acpi-devel@lists.sourceforge.net>,
Dennis Wassenberg <dennis.wassenberg@secunet.com>,
Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for HKEY version 0x200
Date: Tue, 7 Jun 2016 14:43:00 -0700 [thread overview]
Message-ID: <20160607214300.GA3829@f23x64.localdomain> (raw)
In-Reply-To: <1465333851.7166.46.camel@redhat.com>
On Tue, Jun 07, 2016 at 05:10:51PM -0400, Lyude Paul wrote:
> Managed to find someone in the office with one of these laptops and it looks
> like the adaptive keyboard works perfectly with this patch, so I can give my t-
> b:
>
> Tested-by: Lyude Paul <cpaul@redhat.com>
>
> Cheers,
> Lyude
>
> On Tue, 2016-06-07 at 13:02 -0400, Lyude Paul wrote:
> > Since nothing's really happened with this patch for a while I figured I'd take
> > over trying to get this upstream.
> >
> > Regarding testing: This seems to work fine on the 60 series laptops, and works
> > fine on previous generations. The one thing I haven't been able to test is an
> > X1
> > carbon with an adaptive keyboard since I don't seem to have one readily
> > available here. I'm doing a search around the office to try to find someone
> > who
> > didn't throw theirs away yet so hopefully I should be able to get back to you
> > on
> > that soon.
> >
> > To Dennis: I took the liberty of doing a review of your patch and some
> > testing.
> > There's a few things that need changing, I've outlined them below: (for the
> > future, it's recommended to send patches for the kernel inline in emails to
> > make
> > them easier to review).
If someone would please update the patch with any pending changes from review
and so it follows the rules in Documentation/SubmittingPatches, including the
complete list of recipients on Cc, we can move this forward.
Regards,
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2016-06-07 21:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 17:02 [PATCH] thinkpad_acpi: Add support for HKEY version 0x200 Lyude Paul
2016-06-07 21:10 ` [ibm-acpi-devel] " Lyude Paul
2016-06-07 21:43 ` Darren Hart [this message]
2016-06-07 22:06 ` Marco Trevisan (Treviño)
2016-06-07 23:53 ` Henrique de Moraes Holschuh
2016-06-08 14:54 ` [PATCH v2] " Lyude
2016-06-08 19:30 ` Darren Hart
2016-06-09 5:05 ` [ibm-acpi-devel] " Marco Trevisan (Treviño)
2016-06-09 19:57 ` Darren Hart
2016-06-09 21:04 ` Henrique de Moraes Holschuh
2016-06-09 21:18 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607214300.GA3829@f23x64.localdomain \
--to=dvhart@infradead.org \
--cc=cpaul@redhat.com \
--cc=dennis.wassenberg@secunet.com \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).