From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933241AbcFGVnN (ORCPT ); Tue, 7 Jun 2016 17:43:13 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:51525 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932424AbcFGVnM (ORCPT ); Tue, 7 Jun 2016 17:43:12 -0400 Date: Tue, 7 Jun 2016 14:43:00 -0700 From: Darren Hart To: Lyude Paul Cc: "ibm-acpi-devel@lists.sourceforge.net" , Dennis Wassenberg , Henrique de Moraes Holschuh , "linux-kernel@vger.kernel.org" , platform-driver-x86@vger.kernel.org Subject: Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for HKEY version 0x200 Message-ID: <20160607214300.GA3829@f23x64.localdomain> References: <1465318938.7166.23.camel@redhat.com> <1465333851.7166.46.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465333851.7166.46.camel@redhat.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2016 at 05:10:51PM -0400, Lyude Paul wrote: > Managed to find someone in the office with one of these laptops and it looks > like the adaptive keyboard works perfectly with this patch, so I can give my t- > b: > > Tested-by: Lyude Paul > > Cheers, > Lyude > > On Tue, 2016-06-07 at 13:02 -0400, Lyude Paul wrote: > > Since nothing's really happened with this patch for a while I figured I'd take > > over trying to get this upstream. > > > > Regarding testing: This seems to work fine on the 60 series laptops, and works > > fine on previous generations. The one thing I haven't been able to test is an > > X1 > > carbon with an adaptive keyboard since I don't seem to have one readily > > available here. I'm doing a search around the office to try to find someone > > who > > didn't throw theirs away yet so hopefully I should be able to get back to you > > on > > that soon. > > > > To Dennis: I took the liberty of doing a review of your patch and some > > testing. > > There's a few things that need changing, I've outlined them below: (for the > > future, it's recommended to send patches for the kernel inline in emails to > > make > > them easier to review). If someone would please update the patch with any pending changes from review and so it follows the rules in Documentation/SubmittingPatches, including the complete list of recipients on Cc, we can move this forward. Regards, -- Darren Hart Intel Open Source Technology Center