From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
netdev@vger.kernel.org, mpe@ellerman.id.au,
Matt Evans <matt@ozlabs.org>,
Denis Kirjanov <kda@linux-powerpc.org>,
Paul Mackerras <paulus@samba.org>,
Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Subject: Re: [PATCH 6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF
Date: Tue, 7 Jun 2016 15:56:11 -0700 [thread overview]
Message-ID: <20160607225609.GA40706@ast-mbp.thefacebook.com> (raw)
In-Reply-To: <908d3552b5eb240b28f70aee7c4c86e2b600aa02.1465304785.git.naveen.n.rao@linux.vnet.ibm.com>
On Tue, Jun 07, 2016 at 07:02:23PM +0530, Naveen N. Rao wrote:
> PPC64 eBPF JIT compiler.
>
> Enable with:
> echo 1 > /proc/sys/net/core/bpf_jit_enable
> or
> echo 2 > /proc/sys/net/core/bpf_jit_enable
>
> ... to see the generated JIT code. This can further be processed with
> tools/net/bpf_jit_disasm.
>
> With CONFIG_TEST_BPF=m and 'modprobe test_bpf':
> test_bpf: Summary: 305 PASSED, 0 FAILED, [297/297 JIT'ed]
>
> ... on both ppc64 BE and LE.
Nice. That's even better than on x64 which cannot jit one test:
test_bpf: #262 BPF_MAXINSNS: Jump, gap, jump, ... jited:0 168 PASS
which was designed specifically to hit x64 jit pass limit.
ppc jit has predicatble number of passes and doesn't have this problem
as expected. Great.
> The details of the approach are documented through various comments in
> the code.
>
> Cc: Matt Evans <matt@ozlabs.org>
> Cc: Denis Kirjanov <kda@linux-powerpc.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Alexei Starovoitov <ast@fb.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> ---
> arch/powerpc/Kconfig | 3 +-
> arch/powerpc/include/asm/asm-compat.h | 2 +
> arch/powerpc/include/asm/ppc-opcode.h | 20 +-
> arch/powerpc/net/Makefile | 4 +
> arch/powerpc/net/bpf_jit.h | 53 +-
> arch/powerpc/net/bpf_jit64.h | 102 ++++
> arch/powerpc/net/bpf_jit_asm64.S | 180 +++++++
> arch/powerpc/net/bpf_jit_comp64.c | 956 ++++++++++++++++++++++++++++++++++
> 8 files changed, 1317 insertions(+), 3 deletions(-)
> create mode 100644 arch/powerpc/net/bpf_jit64.h
> create mode 100644 arch/powerpc/net/bpf_jit_asm64.S
> create mode 100644 arch/powerpc/net/bpf_jit_comp64.c
don't see any issues with the code.
Thank you for working on this.
Acked-by: Alexei Starovoitov <ast@kernel.org>
next prev parent reply other threads:[~2016-06-07 22:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 13:32 [PATCH 0/6] eBPF JIT for PPC64 Naveen N. Rao
2016-06-07 13:32 ` [PATCH 1/6] ppc: bpf/jit: Fix/enhance 32-bit Load Immediate implementation Naveen N. Rao
2016-06-07 13:32 ` [PATCH 2/6] ppc: bpf/jit: Optimize 64-bit Immediate loads Naveen N. Rao
2016-06-07 13:32 ` [PATCH 3/6] ppc: bpf/jit: Introduce rotate immediate instructions Naveen N. Rao
2016-06-07 13:32 ` [PATCH 4/6] ppc: bpf/jit: A few cleanups Naveen N. Rao
2016-06-07 13:32 ` [PATCH 5/6] ppc: bpf/jit: Isolate classic BPF JIT specifics into a separate header Naveen N. Rao
2016-06-07 13:32 ` [PATCH 6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF Naveen N. Rao
2016-06-07 22:56 ` Alexei Starovoitov [this message]
2016-06-08 17:17 ` Naveen N. Rao
2016-06-09 3:19 ` Nilay Vaish
2016-06-09 6:07 ` Naveen N. Rao
2016-06-17 12:53 ` [6/6] " Michael Ellerman
2016-06-17 13:00 ` [PATCH] ppc: Fix BPF JIT for ABIv2 Thadeu Lima de Souza Cascardo
2016-06-19 17:49 ` Naveen N. Rao
2016-06-20 18:56 ` Thadeu Lima de Souza Cascardo
2016-06-21 8:58 ` Naveen N. Rao
2016-06-21 11:15 ` Michael Ellerman
2016-06-21 14:47 ` Thadeu Lima de Souza Cascardo
2016-06-21 15:45 ` Alexei Starovoitov
2016-06-22 4:06 ` Michael Ellerman
2016-06-22 7:12 ` Naveen N. Rao
2016-06-22 14:57 ` Naveen N. Rao
2016-06-22 5:20 ` Michael Ellerman
2016-06-22 5:18 ` Michael Ellerman
2016-06-19 17:36 ` [6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF Naveen N. Rao
2016-06-20 23:38 ` Michael Ellerman
2016-06-21 6:58 ` Naveen N. Rao
2016-06-21 11:04 ` Michael Ellerman
2016-06-22 7:06 ` Naveen N. Rao
2016-06-22 10:37 ` [PATCH 6/6] " Michael Ellerman
2016-06-22 12:32 ` Naveen N. Rao
2016-06-11 5:47 ` [PATCH 0/6] eBPF JIT for PPC64 David Miller
2016-06-13 5:40 ` Naveen N. Rao
2016-06-18 4:57 ` mpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607225609.GA40706@ast-mbp.thefacebook.com \
--to=alexei.starovoitov@gmail.com \
--cc=ananth@in.ibm.com \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kda@linux-powerpc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matt@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).