linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jarod@redhat.com
Cc: bkenward@solarflare.com, linux-kernel@vger.kernel.org,
	linux-net-drivers@solarflare.com, ecree@solarflare.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH net v2] sfc: report supported link speeds on SFP connections
Date: Wed, 08 Jun 2016 11:19:14 -0700 (PDT)	[thread overview]
Message-ID: <20160608.111914.164051676271541750.davem@davemloft.net> (raw)
In-Reply-To: <20160608134114.GJ56933@redhat.com>

From: Jarod Wilson <jarod@redhat.com>
Date: Wed, 8 Jun 2016 09:41:14 -0400

> On Tue, Jun 07, 2016 at 05:20:16PM -0400, Jarod Wilson wrote:
>> On Mon, Jun 06, 2016 at 02:55:29PM -0400, Jarod Wilson wrote:
>> > On Mon, Jun 06, 2016 at 05:29:30PM +0100, Bert Kenward wrote:
>> > > 7000-series SFC NICs connected with an SFP+ module currently fail to
>> > > report any supported link speeds.
>> > > 
>> > > Reported-by: Jarod Wilson <jarod@redhat.com>
>> > > Signed-off-by: Bert Kenward <bkenward@solarflare.com>
>> > 
>> > Had a feeling my cut might not have been quite right. Looks good to me.
>> > 
>> > Reviewed-by: Jarod Wilson <jarod@redhat.com>
>> 
>> ...however, upon testing, there's a gotcha. This results in my 10Gbps sfc
>> nic reporting that it supports 40Gbps:
>> 
>> $ ethtool ens4f0
>> Settings for ens4f0:
>> 	Supported ports: [ FIBRE ]
>> 	Supported link modes:   1000baseT/Full
>> 	                        10000baseT/Full
>> 	                        40000baseKR4/Full
> 
> This turned out to be a flub on my part. My local tree wasn't clean, had
> some lingering test/debug crap in it that I thought I'd removed, but
> clearly, hadn't. With that removed, we're all good here.
> 
> Tested-by: Jarod Wilson <jarod@redhat.com>

Thanks for following up.

Applied, thanks everyone.

      reply	other threads:[~2016-06-08 18:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03  1:33 [PATCH net] ethernet/sfc: report supported link speeds on SFP connections Jarod Wilson
2016-06-03 23:50 ` David Miller
2016-06-06 15:07 ` Bert Kenward
2016-06-06 16:29 ` [PATCH net v2] sfc: " Bert Kenward
2016-06-06 18:55   ` Jarod Wilson
2016-06-07 21:20     ` Jarod Wilson
2016-06-08 13:41       ` Jarod Wilson
2016-06-08 18:19         ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160608.111914.164051676271541750.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bkenward@solarflare.com \
    --cc=ecree@solarflare.com \
    --cc=jarod@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net-drivers@solarflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).