From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161705AbcFHFtu (ORCPT ); Wed, 8 Jun 2016 01:49:50 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([207.82.80.143]:41340 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751535AbcFHFts convert rfc822-to-8bit (ORCPT ); Wed, 8 Jun 2016 01:49:48 -0400 Date: Wed, 8 Jun 2016 13:49:05 +0800 From: Huang Shijie To: David Long CC: Catalin Marinas , James Morse , Marc Zyngier , Pratyush Anand , Sandeepa Prabhu , "Will Deacon" , William Cohen , , , "Steve Capper" , Masami Hiramatsu , "Li Bin" , Adam Buchbinder , Alex =?iso-8859-1?Q?Benn=E9e?= , Andrew Morton , Andrey Ryabinin , "Ard Biesheuvel" , Christoffer Dall , Daniel Thompson , Dave P Martin , Jens Wiklander , Jisheng Zhang , "John Blackwood" , Mark Rutland , Petr Mladek , Robin Murphy , "Suzuki K Poulose" , Vladimir Murzin , Yang Shi , Zi Shen Lim , yalin wang , Mark Brown , Subject: Re: [PATCH v13 10/10] kprobes: Add arm64 case in kprobe example module Message-ID: <20160608054903.GA8198@sha-win-210.asiapac.arm.com> References: <1464924384-15269-1-git-send-email-dave.long@linaro.org> <1464924384-15269-11-git-send-email-dave.long@linaro.org> MIME-Version: 1.0 In-Reply-To: <1464924384-15269-11-git-send-email-dave.long@linaro.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [101.230.208.200] X-ClientProxiedBy: TY1PR06CA0012.apcprd06.prod.outlook.com (10.164.91.22) To DB5PR08MB0504.eurprd08.prod.outlook.com (10.161.245.17) X-MS-Office365-Filtering-Correlation-Id: 0a3349bd-c412-4444-ebb9-08d38f60afea X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0504;2:8WYig32g0avd1C7PBr5oWrnzFjcb6zV/BVO39O875LkFcGmyMKKkq8VIEjGnlwd9sDimaOmx1qVPNFR3igGGHEcz2yOOjcmmILMNstdpIDwWVlEHOKIj7/yd4Yl3y+vgRIaCUtuk27VqBeHu9RqP7ccJe01qcCza5VSASEHVwvPCgtiv8fiH/XjPXe1gAEB9;3:H7gcKa4iARh/qOjvAl8vTEteZBm6NZlo/3M43GCiuNLZUrVB/S8SPLahqo9Cw1Ul8EG8MbUnXUqLxO6sy7wBpg7ACT3RJTePB3AkpkDJMAEvRJqKwzRUpopKqwS2COii;25:6S4kpwcUhOgvE0GLDHV290Bo3hO9jtpvou3Qsw+pKxTtEcujZnJV67qoDKfeJIpDN5Dlzl4tEN0NobsYowdtMmWBqQWKbtZGa868kVA5QRHvwpTAMgLKLcI76lwapdt3Nc4BwmTB5heNI8VOgZ4PqKAxGohBFVey2CHdZfpwOY2ZYzyxY6yTEPZ99XR8nR6+HOxE17l9zU8Yhdo2+7F888aRzx5Wo9sQQ53YVxKSwwcWBvH9iiHf2SXFpUcL8eJ0ZRgSKvCT1n90a+FS+WN0rVTTw1awyyoLyxFsy+T3Xzy3DI61jTR0r9UEWcNnGVPxWS8dZoyHxzUL3RVVkrGK4nP8cqoqhuERUwpSYsuKSE7CZuFvZtCvVOZsm1DxyEsMnY4v8JoZ9OlMAv90dOBiNhuupJ5Mh2gb02RgdotFYa0=;20:qoLb1BB++dS5dQsYB7IVc4EkNN2ET6x2OFIbpMaImnzzROJmW4v0svKsVufAo3zitIM0VtkaiaPF9hLFb9o5U8jjl2uFvwagIPbM5n3Rb6owz4YYIDbZuMQKEJVXEjeJolF0N89Ye+syZCu/sit3g3r91Fmums43CwPfvgA+OcU= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR08MB0504; NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:DB5PR08MB0504;BCL:0;PCL:0;RULEID:;SRVR:DB5PR08MB0504; X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0504;4:E2F+mJawMbfmvODF/4/OxnOYzrv05tUBt7kHSZMh5TkhH9WY8/HJ4ooeNZ/BZ7zQiS5CpqXUgcOUHjpKOiRFUrHM5ZjRE/1WUVlhPPQ9sV80PQmJHQeDNW+Y+OvkL+OJCO3Ct0AKcagyKEX4h0oX644u87upxYqZUbrYVBE465b0VBZuwxvk30of0HqAw0MSyONjf+kjXm52U7o/3hMPLLnGus6GD7nTESGJ/69Wduv8a5zBOUXXTJtzeYZXXJz2vAxquvhZVsFPxKq0LMj4Rrunfkn/HRFcQEwraQT0eqUH7xqqpcDIkvW7Sg+/rTO8x9LV5THpT1CBfFcoan1MtQX4/a9uQGdx4syE8tYCMYN+w77A654w408f2l/LWxCOh5feSCYzn784BujTo1NVPQ== X-Forefront-PRVS: 0967749BC1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(189002)(199003)(24454002)(5004730100002)(4326007)(50466002)(110136002)(81166006)(77096005)(105586002)(81156014)(575784001)(97736004)(4001350100001)(50986999)(54356999)(2906002)(68736007)(83506001)(189998001)(101416001)(86362001)(8676002)(76176999)(97756001)(586003)(19580395003)(46406003)(19580405001)(33656002)(47776003)(2950100001)(3846002)(6116002)(106356001)(5008740100001)(66066001)(42186005)(92566002)(1076002)(23726003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR08MB0504;H:sha-win-210.asiapac.arm.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB5PR08MB0504;23:RtlVEKLnJw17/dX8l7LvSD26FwGjAI5b9As9f3usx?= =?us-ascii?Q?AO/4yWaMRd6lGYlAnkblK4+eDCcYCPLry3KBSgkvaINe/eb4EqcR2Jk9PUy+?= =?us-ascii?Q?KKWYTe/Evu5la4eEY+EQJbroF29/9bZPIMQx/yjVrhD2fFwGyUHRgN7AiqA1?= =?us-ascii?Q?/VTRCi1wJ4S8Vcd5b5KLoIWRKiJy3Y0IdHrJZ0vHRZQ+2C9J29doNv0O0GqH?= =?us-ascii?Q?2MeYQh5bwX/MdwPqIT6cCM0LrNny0Gil62vqhmEpgLjNt/rbbQim/92AYbQB?= =?us-ascii?Q?ae2Ur19wIXMvMhVm3j7P7lXIvA4R9D1rzHZTG5x98AfC/1qyQsYfvFJlBrl5?= =?us-ascii?Q?ueEDu4iiR0NQqxXeTGrsZun7mnquxfkVXqUenY2enUyjqGGo8MabaWPNtopo?= =?us-ascii?Q?fOF3GLk/YNkBk6JefCDJw0w9TTnn/3kaLRkBWpXrv8JLhLIV6Idg8ohjT4Zy?= =?us-ascii?Q?LaBaJ0hKGEAQo3/ObUo2sFfccNwK+P+yQbE0f28c7ioWL9S16FwYNTgVbItB?= =?us-ascii?Q?j6HsWVCT+hMLWreUTD3urHo7m52s9hvdJFYFLtugNb7n0fZKJfkSVfpWDlUT?= =?us-ascii?Q?UPEeacis+J4QNxB/Nri6kxpm3tVDasEww0uk1H6187Qv5pWYWBU1Ezp15Jgd?= =?us-ascii?Q?M7DhuFjIN4Oc4zSIQ1wyBMpoY08Oa0LSXTWzAgtlUiqNEVmu4CgG30//ratf?= =?us-ascii?Q?BTjx8tAoe4Gm/UgLpPVxJgqsrN8kYoUPT6OfTka9ePMlNMND5GAyyGHbhsXV?= =?us-ascii?Q?Ot3APgkLwuU1TiIoF0lX8/Sz0Je39ftXAh7jL2B/lS8V0DJ8FHwK7kJwoae9?= =?us-ascii?Q?3NgtitZMFL6DN1I9kJK/7/BzLEkKp1g5YTS3VN3FXwww8+44YvJJIt6yxGj2?= =?us-ascii?Q?XhSZYUvt0wJPwqbunIqrf88TCcq1omDpqrun1A9s/9tiaHuVG8fsl3GJfzBE?= =?us-ascii?Q?4wW/QI/ENJ46Xik8zficnHgfwTvWGEy2LQU9WpjjQTWkBXfbFd5xsvZh6tAt?= =?us-ascii?Q?DNnbdSTTdVbPgWtWavb1ByHVJArxbtkPkUCMDYYazv+Y2yzW3WCAqZ8f5uL1?= =?us-ascii?Q?wcfeYQIVE47EQ3Y7sZJ0lHu8SKwsXmCHJU55fY7R//q/NcsuzcEHDgmznlbC?= =?us-ascii?Q?0QKFLYWiy0=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0504;5:+AFHjbpuiHC8+Y1a7pJJkuT5YScWl2q3hochAKY7nCKLOpkHa7kjuhThCwIza530tG5+4SnhBs6YjsO+IreeIQqAydhY9TT39PqtSHcMcg7JgPbIc/nAnoQ6Q1y5LHWHDYzjrcdxSjGwp7BDCIURNA==;24:M/TO+CgJiFMB1YOacEBq+zTB4dVxyt9KwKyMamhm95UMR42hgza62a3EuK0kEWDDozTyQqMmj9/weC6fz2C8BJrBEJ/TCSx7Yo9HXSuhqpM=;7:I+OY41fguLtFdMy9S+rvJE89DRj/yyckbnbJ47omvPagg7ONzYcaN0wXQuAYCTu6m3iiTY5beShSjlkkpZIRVS+P4LVzYBsqB5N/6EGRO/tsWfJ0khw/EeawtlHvLu6hvATlH1+tXl+Yl821IjokqI6oVeQ8XHnF3rrFPoGbOD3lSWtOxmexjW0zlFhKe0Z71Oopb3/kxNm5HiRIf2rTjCFxEEZnBWXvk+pEzfsWxGM=;20:2LDZhSHiBVn7KlfEHuh4/OfZYcs+cPlmjzqttNElfh7lLihQzvrVcozd/BwMqO+tt0ihdkaB089zJeTz2e3HT7OdV6dxqG4jMKMcbmmRwROuOdkI++UTCADe0n6dZleMiSwAnUvglhD6sLTFvOmfYYFAzZyFjPcxrKe/JO4TaD4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2016 05:49:29.7130 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB0504 X-MC-Unique: 4ziiwjFBQqS3zz4TVVHk0g-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 02, 2016 at 11:26:24PM -0400, David Long wrote: > From: Sandeepa Prabhu > > Add info prints in sample kprobe handlers for ARM64 > > Signed-off-by: Sandeepa Prabhu > --- > samples/kprobes/kprobe_example.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c > index ed0ca0c..aad8e6f 100644 > --- a/samples/kprobes/kprobe_example.c > +++ b/samples/kprobes/kprobe_example.c > @@ -46,6 +46,10 @@ static int handler_pre(struct kprobe *p, struct pt_regs *regs) > " ex1 = 0x%lx\n", > p->symbol_name, p->addr, regs->pc, regs->ex1); > #endif > +#ifdef CONFIG_ARM64 > + pr_info("pre_handler: p->addr = 0x%p, pc = 0x%lx\n", > + p->addr, (long)regs->pc); Please add the "p->symbol_name" for the log, just as the above line. > +#endif > > /* A dump_stack() here will give a stack backtrace */ > return 0; > @@ -71,6 +75,10 @@ static void handler_post(struct kprobe *p, struct pt_regs *regs, > printk(KERN_INFO "<%s> post_handler: p->addr = 0x%p, ex1 = 0x%lx\n", > p->symbol_name, p->addr, regs->ex1); > #endif > +#ifdef CONFIG_ARM64 > + pr_info("post_handler: p->addr = 0x%p, pc = 0x%lx\n", > + p->addr, (long)regs->pc); > +#endif > } Ditto. thanks Huang Shijie