From: Greg KH <gregkh@linuxfoundation.org>
To: Rumesh Hapuarachchi <rehrumesh@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: unisys: visorhba: visorhba_main: fixed a coding style issue
Date: Tue, 7 Jun 2016 22:59:58 -0700 [thread overview]
Message-ID: <20160608055958.GA10259@kroah.com> (raw)
In-Reply-To: <1463770846-24457-1-git-send-email-rehrumesh@gmail.com>
On Sat, May 21, 2016 at 12:30:46AM +0530, Rumesh Hapuarachchi wrote:
> fixed checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Rumesh Hapuarahcchi <rehrumesh@gmail.com>
> ---
> drivers/staging/unisys/visorhba/visorhba_main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers/staging/unisys/visorhba/visorhba_main.c
> index 6a4570d..3b69b33 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -1122,9 +1122,9 @@ static int visorhba_probe(struct visor_device *dev)
> if (err < 0)
> goto err_scsi_host_put;
>
> - scsihost->max_id = (unsigned)max.max_id;
> - scsihost->max_lun = (unsigned)max.max_lun;
> - scsihost->cmd_per_lun = (unsigned)max.cmd_per_lun;
> + scsihost->max_id = (unsigned int)max.max_id;
> + scsihost->max_lun = (unsigned int)max.max_lun;
> + scsihost->cmd_per_lun = (unsigned int)max.cmd_per_lun;
> scsihost->max_sectors =
> (unsigned short)(max.max_io_size >> 9);
> scsihost->sg_tablesize =
Someone else sent this patch for this issue before you did, sorry :(
prev parent reply other threads:[~2016-06-08 6:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 19:00 [PATCH] Staging: unisys: visorhba: visorhba_main: fixed a coding style issue Rumesh Hapuarachchi
2016-06-08 5:59 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608055958.GA10259@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rehrumesh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).