From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754824AbcFHHXH (ORCPT <rfc822;w@1wt.eu>);
	Wed, 8 Jun 2016 03:23:07 -0400
Received: from mail-wm0-f44.google.com ([74.125.82.44]:37745 "EHLO
	mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754169AbcFHHXE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 8 Jun 2016 03:23:04 -0400
Date: Wed, 8 Jun 2016 09:22:57 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Wanpeng Li <kernellwp@gmail.com>, Rik van Riel <riel@redhat.com>,
        =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker <fweisbec@gmail.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Wanpeng Li <wanpeng.li@hotmail.com>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Rik van Riel <riel@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full
 dynticks CPU time accounting
Message-ID: <20160608072257.GA9612@gmail.com>
References: <1465355110-21714-1-git-send-email-wanpeng.li@hotmail.com>
 <1465355110-21714-3-git-send-email-wanpeng.li@hotmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1465355110-21714-3-git-send-email-wanpeng.li@hotmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Wanpeng Li <kernellwp@gmail.com> wrote:

> From: Wanpeng Li <wanpeng.li@hotmail.com>
> 
> This patch adds guest steal-time support to full dynticks CPU
> time accounting. After the following commit:
> 
> ff9a9b4c4334 ("sched, time: Switch VIRT_CPU_ACCOUNTING_GEN to jiffy granularity")
> 
> ... time sampling became jiffy based, even if it's still listened
> to ring boundaries, so steal_account_process_tick() is reused
> to account how many 'ticks' are stolen-time, after the last accumulation.

So the 'ring boundary' part still doesn't parse (neither grammatically nor 
logically) - please rephrase it because I have no idea what you want to say here.

Did you want to say:

> ... time sampling became jiffy based, even if it's still being context tracked, 
> so steal_account_process_tick() is reused to account how many 'ticks' are 
> stolen-time, after the last accumulation.

... which makes sense grammatically but does not make sense to me logically. :-/

Rik, Frederic, could you please help out?

Thanks,

	Ingo