From: Mel Gorman <firstname.lastname@example.org> To: Peter Zijlstra <email@example.com> Cc: Josh Poimboeuf <firstname.lastname@example.org>, Ingo Molnar <email@example.com>, firstname.lastname@example.org, Matt Fleming <email@example.com>, Srikar Dronamraju <firstname.lastname@example.org> Subject: Re: [PATCH 2/2] sched/debug: fix deadlock when enabling sched events Date: Wed, 8 Jun 2016 09:13:05 +0100 [thread overview] Message-ID: <20160608081305.GG2527@techsingularity.net> (raw) In-Reply-To: <20160607195448.GL30154@twins.programming.kicks-ass.net> On Tue, Jun 07, 2016 at 09:54:48PM +0200, Peter Zijlstra wrote: > On Tue, Jun 07, 2016 at 02:43:17PM -0500, Josh Poimboeuf wrote: > > 1. Instead of just warning and allowing the tracepoints to be broken, > > I'd argue that it would be better to make them work by forcing > > schedstats enabled and printing a warning about that, which is what's > > Forcing them enabled doesn't make them useful per se; some of these > tracepoint rely on previously recoded state, which now wasn't previously > recorded because back then it was disabled. > This is unfortunately true. It means there is a window when the data is unreliable after the stats are enabled. It is assumed that either someone enabling the stats knows that or is willing to enable them on the command line. -- Mel Gorman SUSE Labs
next prev parent reply other threads:[~2016-06-08 8:13 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-07 19:43 [PATCH 0/2] sched/debug: more schedstats fixes Josh Poimboeuf 2016-06-07 19:43 ` [PATCH 1/2] sched/debug: fix 'schedstats=enable' cmdline option Josh Poimboeuf 2016-06-08 8:06 ` Mel Gorman 2016-06-08 14:21 ` [tip:sched/core] sched/debug: Fix " tip-bot for Josh Poimboeuf 2016-06-07 19:43 ` [PATCH 2/2] sched/debug: fix deadlock when enabling sched events Josh Poimboeuf 2016-06-07 19:54 ` Peter Zijlstra 2016-06-07 21:02 ` Josh Poimboeuf 2016-06-08 8:13 ` Mel Gorman [this message] 2016-06-07 21:06 ` Josh Poimboeuf 2016-06-08 7:56 ` Ingo Molnar 2016-06-08 13:12 ` Josh Poimboeuf 2016-06-08 13:15 ` Ingo Molnar 2016-06-13 7:32 ` [PATCH v2] " Josh Poimboeuf 2016-06-14 11:35 ` [tip:sched/urgent] sched/debug: Fix " tip-bot for Josh Poimboeuf 2016-06-08 8:11 ` [PATCH 2/2] sched/debug: fix " Mel Gorman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160608081305.GG2527@techsingularity.net \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 2/2] sched/debug: fix deadlock when enabling sched events' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).