linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: Remove site specific OOM error message
@ 2016-06-07 17:50 Peter Griffin
  2016-06-07 17:50 ` [PATCH 2/2] phy: phy-qcom-ufs-qmp-20nm: " Peter Griffin
  2016-06-07 18:35 ` [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: " Baruch Siach
  0 siblings, 2 replies; 4+ messages in thread
From: Peter Griffin @ 2016-06-07 17:50 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel, kishon; +Cc: peter.griffin, patches, lee.jones

kzalloc will issue its own error message including a dump_stack()
so remote the site specific message.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 drivers/phy/phy-qcom-ufs-qmp-14nm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/phy/phy-qcom-ufs-qmp-14nm.c b/drivers/phy/phy-qcom-ufs-qmp-14nm.c
index 56631e7..958e9cc 100644
--- a/drivers/phy/phy-qcom-ufs-qmp-14nm.c
+++ b/drivers/phy/phy-qcom-ufs-qmp-14nm.c
@@ -139,11 +139,9 @@ static int ufs_qcom_phy_qmp_14nm_probe(struct platform_device *pdev)
 	int err = 0;
 
 	phy = devm_kzalloc(dev, sizeof(*phy), GFP_KERNEL);
-	if (!phy) {
-		dev_err(dev, "%s: failed to allocate phy\n", __func__);
+	if (!phy)
 		err = -ENOMEM;
 		goto out;
-	}
 
 	generic_phy = ufs_qcom_phy_generic_probe(pdev, &phy->common_cfg,
 				&ufs_qcom_phy_qmp_14nm_phy_ops, &phy_14nm_ops);
-- 
1.9.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] phy: phy-qcom-ufs-qmp-20nm: Remove site specific OOM error message
  2016-06-07 17:50 [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: Remove site specific OOM error message Peter Griffin
@ 2016-06-07 17:50 ` Peter Griffin
  2016-06-07 18:35 ` [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: " Baruch Siach
  1 sibling, 0 replies; 4+ messages in thread
From: Peter Griffin @ 2016-06-07 17:50 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel, kishon; +Cc: peter.griffin, patches, lee.jones

kzalloc will issue its own error message including a dump_stack()
so remote the site specific message.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 drivers/phy/phy-qcom-ufs-qmp-20nm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/phy/phy-qcom-ufs-qmp-20nm.c b/drivers/phy/phy-qcom-ufs-qmp-20nm.c
index b16ea77..97a2414 100644
--- a/drivers/phy/phy-qcom-ufs-qmp-20nm.c
+++ b/drivers/phy/phy-qcom-ufs-qmp-20nm.c
@@ -195,11 +195,9 @@ static int ufs_qcom_phy_qmp_20nm_probe(struct platform_device *pdev)
 	int err = 0;
 
 	phy = devm_kzalloc(dev, sizeof(*phy), GFP_KERNEL);
-	if (!phy) {
-		dev_err(dev, "%s: failed to allocate phy\n", __func__);
+	if (!phy)
 		err = -ENOMEM;
 		goto out;
-	}
 
 	generic_phy = ufs_qcom_phy_generic_probe(pdev, &phy->common_cfg,
 				&ufs_qcom_phy_qmp_20nm_phy_ops, &phy_20nm_ops);
-- 
1.9.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: Remove site specific OOM error message
  2016-06-07 17:50 [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: Remove site specific OOM error message Peter Griffin
  2016-06-07 17:50 ` [PATCH 2/2] phy: phy-qcom-ufs-qmp-20nm: " Peter Griffin
@ 2016-06-07 18:35 ` Baruch Siach
  2016-06-08  8:46   ` Peter Griffin
  1 sibling, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2016-06-07 18:35 UTC (permalink / raw)
  To: Peter Griffin; +Cc: linux-arm-kernel, linux-kernel, kishon, lee.jones, patches

Hi Peter,

On Tue, Jun 07, 2016 at 06:50:09PM +0100, Peter Griffin wrote:
> kzalloc will issue its own error message including a dump_stack()
> so remote the site specific message.
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
>  drivers/phy/phy-qcom-ufs-qmp-14nm.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/phy/phy-qcom-ufs-qmp-14nm.c b/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> index 56631e7..958e9cc 100644
> --- a/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> +++ b/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> @@ -139,11 +139,9 @@ static int ufs_qcom_phy_qmp_14nm_probe(struct platform_device *pdev)
>  	int err = 0;
>  
>  	phy = devm_kzalloc(dev, sizeof(*phy), GFP_KERNEL);
> -	if (!phy) {
> -		dev_err(dev, "%s: failed to allocate phy\n", __func__);
> +	if (!phy)
>  		err = -ENOMEM;
>  		goto out;
> -	}

Are you sure? The 'goto' is now unconditional.

>  
>  	generic_phy = ufs_qcom_phy_generic_probe(pdev, &phy->common_cfg,
>  				&ufs_qcom_phy_qmp_14nm_phy_ops, &phy_14nm_ops);

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: Remove site specific OOM error message
  2016-06-07 18:35 ` [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: " Baruch Siach
@ 2016-06-08  8:46   ` Peter Griffin
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Griffin @ 2016-06-08  8:46 UTC (permalink / raw)
  To: Baruch Siach; +Cc: linux-arm-kernel, linux-kernel, kishon, lee.jones, patches

Hi Baruch,

On Tue, 07 Jun 2016, Baruch Siach wrote:

> Hi Peter,
> 
> On Tue, Jun 07, 2016 at 06:50:09PM +0100, Peter Griffin wrote:
> > kzalloc will issue its own error message including a dump_stack()
> > so remote the site specific message.
> > 
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > ---
> >  drivers/phy/phy-qcom-ufs-qmp-14nm.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/phy/phy-qcom-ufs-qmp-14nm.c b/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> > index 56631e7..958e9cc 100644
> > --- a/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> > +++ b/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> > @@ -139,11 +139,9 @@ static int ufs_qcom_phy_qmp_14nm_probe(struct platform_device *pdev)
> >  	int err = 0;
> >  
> >  	phy = devm_kzalloc(dev, sizeof(*phy), GFP_KERNEL);
> > -	if (!phy) {
> > -		dev_err(dev, "%s: failed to allocate phy\n", __func__);
> > +	if (!phy)
> >  		err = -ENOMEM;
> >  		goto out;
> > -	}
> 
> Are you sure? The 'goto' is now unconditional.

Your correct... that is not what I intended to do! Will send a v2.

regards,

Peter.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-06-08  8:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-07 17:50 [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: Remove site specific OOM error message Peter Griffin
2016-06-07 17:50 ` [PATCH 2/2] phy: phy-qcom-ufs-qmp-20nm: " Peter Griffin
2016-06-07 18:35 ` [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: " Baruch Siach
2016-06-08  8:46   ` Peter Griffin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).