From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422872AbcFHIqx (ORCPT ); Wed, 8 Jun 2016 04:46:53 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:34849 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161215AbcFHIqu (ORCPT ); Wed, 8 Jun 2016 04:46:50 -0400 Date: Wed, 8 Jun 2016 09:46:45 +0100 From: Peter Griffin To: Baruch Siach Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kishon@ti.com, lee.jones@linaro.org, patches@linaro.org Subject: Re: [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: Remove site specific OOM error message Message-ID: <20160608084645.GA25004@griffinp-ThinkPad-X1-Carbon-2nd> References: <1465321810-22470-1-git-send-email-peter.griffin@linaro.org> <20160607183505.GJ2425@tarshish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160607183505.GJ2425@tarshish> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Baruch, On Tue, 07 Jun 2016, Baruch Siach wrote: > Hi Peter, > > On Tue, Jun 07, 2016 at 06:50:09PM +0100, Peter Griffin wrote: > > kzalloc will issue its own error message including a dump_stack() > > so remote the site specific message. > > > > Signed-off-by: Peter Griffin > > --- > > drivers/phy/phy-qcom-ufs-qmp-14nm.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/phy/phy-qcom-ufs-qmp-14nm.c b/drivers/phy/phy-qcom-ufs-qmp-14nm.c > > index 56631e7..958e9cc 100644 > > --- a/drivers/phy/phy-qcom-ufs-qmp-14nm.c > > +++ b/drivers/phy/phy-qcom-ufs-qmp-14nm.c > > @@ -139,11 +139,9 @@ static int ufs_qcom_phy_qmp_14nm_probe(struct platform_device *pdev) > > int err = 0; > > > > phy = devm_kzalloc(dev, sizeof(*phy), GFP_KERNEL); > > - if (!phy) { > > - dev_err(dev, "%s: failed to allocate phy\n", __func__); > > + if (!phy) > > err = -ENOMEM; > > goto out; > > - } > > Are you sure? The 'goto' is now unconditional. Your correct... that is not what I intended to do! Will send a v2. regards, Peter.